Repository navigation
wolfssh: warn when a known host adds a key type - #1345
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1345
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
dc59aa9 to
5b201d1
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1345
Scan targets checked: none
Unchanged since last review (not re-run): wolfssh-src, wolfssh-bugs
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
The known_hosts search skips an entry whose host matches but whose key type differs, so a host pinned with one type that presents another was reported as an unknown host. The check now remembers that the host is known with another type and says so before offering to add the new one, as OpenSSH does. - note the first other-type entry's key type and line in the loop - print a warning with that entry, the host and the new fingerprint before the add prompt; a later same-type entry still matches or rejects as before - reject a server key type that is not printable ASCII before it is printed or stored - regress.c: add TestKnownHostsOtherType Issue: ZD-22634
5b201d1 to
4aae9d0
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1345
Scan targets checked: none
Unchanged since last review (not re-run): wolfssh-src, wolfssh-bugs
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
The wolfssh client reported a host pinned in known_hosts with one key
type that presented another as an unknown host. It now says the host is
known with a different key type, naming the pinned entry, before asking.
different key, as before.
printed or stored.
Issue: ZD-22634