Move WOLFSSL_X509_TINY test to the unit test suite and run - #10975
Open
aidangarske wants to merge 1 commit into
Open
Move WOLFSSL_X509_TINY test to the unit test suite and run#10975aidangarske wants to merge 1 commit into
aidangarske wants to merge 1 commit into
Conversation
aidangarske
force-pushed
the
x509-tiny-ci
branch
from
July 22, 2026 21:50
92c18e6 to
60768c6
Compare
aidangarske
marked this pull request as ready for review
July 22, 2026 21:59
|
retest this please |
aidangarske
force-pushed
the
x509-tiny-ci
branch
from
July 22, 2026 22:30
60768c6 to
6c04755
Compare
Frauschi
reviewed
Jul 23, 2026
Frauschi
left a comment
Frauschi
left a comment
Contributor
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 2 total — 2 posted, 0 skipped
Posted findings
- [Low] critUnknown assertion gated on WOLFSSL_NO_ASN_STRICT, but the code does not relax it —
tests/api.c:3866-3872 - [Info] Double blank line after the moved test function —
tests/api.c:3887-3889
Review generated by Skoll via Claude/Codex
aidangarske
force-pushed
the
x509-tiny-ci
branch
from
July 31, 2026 21:02
30e1287 to
d20328e
Compare
Frauschi
reviewed
Aug 3, 2026
Frauschi
left a comment
Frauschi
left a comment
Contributor
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 7 total — 4 posted, 3 skipped
Posted findings
- [Medium] tinyCert_plain assertion proves nothing TINY-specific —
tests/api.c:3856-3862 - [Medium] No CI coverage for any WOLFSSL_X509_TINY add-back macro —
.github/workflows/os-check.yml:452-455 - [Medium] TINY coverage lost for cryptonly / embedded builds —
tests/api.c:3854 - [Low] tinyCert_plain has a one-year validity while its siblings have ten —
tests/api.c:3735-3745
Skipped findings
- [Medium] Critical-extension case duplicates existing coverage and misses the TINY-specific reject paths
- [Low] "check": false silently opts the config out of --private-dir=certs
- [Low] Test name does not follow the api.c wolfCrypt-test convention
Review generated by Skoll via Claude/Codex
aidangarske
force-pushed
the
x509-tiny-ci
branch
from
August 3, 2026 18:44
92c7198 to
0d4cb99
Compare
aidangarske
force-pushed
the
x509-tiny-ci
branch
from
August 3, 2026 19:03
0d4cb99 to
7d37c9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description