Skip to content

Add support for wolfHAL crypto backend - #11033

Draft
AlexLanzano wants to merge 1 commit into
wolfSSL:masterfrom
AlexLanzano:wolfHAL-integration
Draft

Add support for wolfHAL crypto backend#11033
AlexLanzano wants to merge 1 commit into
wolfSSL:masterfrom
AlexLanzano:wolfHAL-integration

Conversation

@AlexLanzano

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings August 2, 2026 21:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new wolfCrypt hardware-acceleration port that routes selected crypto operations through the wolfHAL driver stack via the wolfSSL crypto-callback framework, plus the autotools plumbing to build it.

Changes:

  • Adds a new wolfHAL port implementation (wolfhal.c/.h) with crypto-callback dispatch for AES (ECB/CBC/GCM/CCM) and optional RNG support.
  • Introduces wolfhal_settings.h and wires it into settings.h early to enable WOLF_CRYPTO_CB and map WC_USE_DEVID for wolfHAL builds.
  • Extends autotools build/configure flow (configure.ac, include.am) to enable the port via --with-wolfhal / --with-wolfhal-board, and to register the device during wolfCrypt_Init().

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
wolfssl/wolfcrypt/settings.h Includes wolfHAL macro-only settings early during configuration.
wolfssl/wolfcrypt/port/wolfHAL/wolfhal.h Public port header exposing register/unregister and optional RNG entrypoint.
wolfssl/wolfcrypt/port/wolfHAL/wolfhal_settings.h Macro-only configuration enabling crypto callback + devId mapping.
wolfssl/wolfcrypt/include.am Adds wolfHAL headers to autotools header lists and conditional installs.
wolfcrypt/src/wc_port.c Registers the wolfHAL crypto-callback device during wolfCrypt_Init().
wolfcrypt/src/port/wolfHAL/wolfhal.c Implements crypto callback dispatch to wolfHAL AES + RNG APIs.
wolfcrypt/src/port/wolfHAL/README.md Documents build flags, board.h contract, and runtime initialization order.
wolfcrypt/src/include.am Adds wolfHAL source/README to autotools distribution and conditional build sources.
configure.ac Adds --with-wolfhal / --with-wolfhal-board configuration and build conditionals.
Suppressed comments (1)

configure.ac:3683

  • The board include path is appended without quoting, so --with-wolfhal-board paths containing spaces will be split into multiple compiler arguments and fail to find board.h.
    AM_CFLAGS="$AM_CFLAGS -I$ENABLED_WOLFHAL_BOARD"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread configure.ac
Comment on lines +3642 to +3645
if test -e $trywolfhaldir/wolfHAL/crypto/crypto.h
then
AM_CFLAGS="$AM_CFLAGS -I$trywolfhaldir"
else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants