checks: don't panic on a DT_SONAME without .so in it#2017
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfictl check so-namepanics withindex out of range [1] with length 1when an ELF in the apk has a DT_SONAME that doesn't contain.so.getSonameFiles appends the raw DT_SONAME string to the file list as-is. Unlike the filenames picked up by the regex, that string is just whatever the linker was told to put there, so
libevilorbadsonameare both legal and neither splits on.so. checkSonamesMatch then doesstrings.Split(soname, ".so")[1]in both loops and blows up.Fix is to skip a soname with no
.soin it, since there's no version to compare in that case. Both loops needed it (the existing-package one at the map build, and the new-package one below it).Added two rows to the existing checkSonamesMatch table test covering each side. They panic before the change and pass after.
go test ./pkg/checks/is green.