Down-convert OAS 3.1 constructs for SDK generation - #6
Merged
Conversation
rpanfili
marked this pull request as ready for review
July 17, 2026 15:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish.yaml's "Generate the SDK" step fails spec validation becauseopenapi-mergealways declares the merged output asopenapi: 3.0.3regardless of what any input file says. 9 of 22 merged specs genuinely target OAS 3.1, and their JSON Schema 2020-12 constructs (e.g.graph-sync.yaml's schema-levelexampleslist, from FastAPI/Pydantic v2) are invalid under 3.0 — causingopenapi-generator-clito reject the spec.Also fixes: the generated
python.ymlworkflow was failing separately withError: The version '3.7' ... was not found for Ubuntu 24.04— unrelated to the OAS 3.1/3.0 fix above, but discovered while validating this PR's CI. Python 3.7 is EOL and was never this client's actual supported floor (both publish.yaml's own test job and config.json start at 3.8); GitHub's runners simply stopped shipping it. The version comes fromopenapi-generator-cli's bundled CI template, pinned here at a 2024-05 release — upstream has since fixed this, we just don't consume that fix yet. Marked.github/workflows/python.ymlas hand-maintained (.openapi-generator-ignore) so this survives future SDK regenerations, rather than silently reverting on the next release.