V2#45
Conversation
Review Summary by QodoAdd conventional commits support to semantic release
WalkthroughsDescription• Add conventional commits preset to semantic-release plugins • Configure commit-analyzer with conventionalcommits preset • Configure release-notes-generator with conventionalcommits preset • Bump package version to 2.0.0 • Minor formatting adjustments in configuration Diagramflowchart LR
A["release.config.js"] -->|"Add conventionalcommits preset"| B["commit-analyzer plugin"]
A -->|"Add conventionalcommits preset"| C["release-notes-generator plugin"]
D["package.json"] -->|"Update version"| E["2.0.0"]
File Changes1. release.config.js
|
Code Review by Qodo
1. Duplicate notes generator
|
| [ | ||
| "@semantic-release/release-notes-generator", | ||
| { | ||
| preset: "conventionalcommits", // 👈 Add this for consistent notes | ||
| }, | ||
| ], | ||
| "@semantic-release/release-notes-generator", |
There was a problem hiding this comment.
1. Duplicate notes generator 🐞 Bug ≡ Correctness
release.config.js includes @semantic-release/release-notes-generator twice (one configured with preset, one unconfigured), so the generateNotes step will run twice and can duplicate/override release notes written to the changelog/GitHub release.
Agent Prompt
### Issue description
`release.config.js` configures `@semantic-release/release-notes-generator` with the `conventionalcommits` preset, but also leaves a second unconfigured `@semantic-release/release-notes-generator` entry in the plugins list. This results in the `generateNotes` phase being executed twice, potentially producing duplicated or inconsistent release notes.
### Issue Context
CI runs `npx semantic-release`, which loads `release.config.js` by default.
### Fix Focus Areas
- release.config.js[10-16]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| @@ -1,23 +1,30 @@ | |||
| export default { | |||
| branches: [{ name: "v1", channel: "v1" }, "main"], | |||
There was a problem hiding this comment.
2. V2 branch not configured 🐞 Bug ☼ Reliability
CI runs semantic-release on v* branches, but release.config.js only declares v1 (plus main) as release branches, so pushes on v2 will not follow the intended versioned-branch release channel configuration.
Agent Prompt
### Issue description
The workflow triggers semantic-release on any `v*` branch, but `release.config.js` only lists `{ name: "v1", channel: "v1" }` and `main`. This mismatch means `v2` pushes won’t be treated as a configured release branch/channel.
### Issue Context
`versioned.yml` runs on `v*` branches and executes `npx semantic-release`.
### Fix Focus Areas
- release.config.js[1-3]
- .github/workflows/versioned.yml[3-7]
- .github/workflows/versioned.yml[37-56]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.