Skip to content

Fix failing test#152

Merged
swissspidy merged 1 commit into
mainfrom
fix/tests
May 16, 2026
Merged

Fix failing test#152
swissspidy merged 1 commit into
mainfrom
fix/tests

Conversation

@swissspidy
Copy link
Copy Markdown
Member

The Release Notes plugin was closed on May 15

The Release Notes plugin was closed on May 15
Copilot AI review requested due to automatic review settings May 16, 2026 09:55
@swissspidy swissspidy requested a review from a team as a code owner May 16, 2026 09:55
@swissspidy swissspidy added this to the 2.3.4 milestone May 16, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'Soft changes are only reported in strict mode' scenario in the checksum-plugin.feature file by replacing the release-notes plugin with voice-search. However, this change also removes the verification for README.md files as soft changes. Feedback indicates that this reduces test coverage for the soft change logic and suggests using a plugin that includes both readme.txt and README.md, or adding a separate scenario to maintain full coverage.

Comment thread features/checksum-plugin.feature
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates a plugin checksum feature test after the previously used Release Notes plugin became unavailable.

Changes:

  • Replaces release-notes with voice-search in the soft-change checksum scenario.
  • Removes the second soft-change assertion that previously covered README.md.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread features/checksum-plugin.feature
@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy merged commit 071e3e6 into main May 16, 2026
67 checks passed
@swissspidy swissspidy deleted the fix/tests branch May 16, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants