Tests: Further improve Windows compatibility#327
Conversation
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
There was a problem hiding this comment.
Code Review
This pull request updates a wp eval command in features/core.feature to use double quotes, which improves compatibility with Windows environments. The reviewer recommends extending this change to other similar commands within the same file to ensure consistency and prevent parsing issues across the entire test suite.
features/core.feature
Outdated
| And the return code should be 0 | ||
| When I run `wp eval 'echo $GLOBALS["current_site"]->domain;'` | ||
| When I run `wp eval "echo $GLOBALS['current_site']->domain;"` |
There was a problem hiding this comment.
While this change improves Windows compatibility for this command, other wp eval calls in this file still use single quotes (e.g., on line 249), which can cause parsing issues on Windows. For consistency and to fully address the compatibility issue, please consider updating all wp eval calls in this file to use double quotes for the command argument.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
No description provided.