Conversation
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Code Review
This pull request improves the cross-platform compatibility of the test suite by replacing inline wp eval commands with wp eval-file and switching from single to double quotes for command arguments in Behat feature files. These changes help avoid shell escaping issues, particularly on Windows. Feedback indicates that the transition to double quotes in features/post-block.feature was incomplete, as several instances (e.g., lines 1232 and 1248) were missed and should be updated for consistency.
| Scenario: Check if a post has blocks | ||
| Given a WP install | ||
| When I run `wp post create --post_title='Block Post' --post_content='<!-- wp:paragraph --><p>Hello</p><!-- /wp:paragraph -->' --porcelain` | ||
| When I run `wp post create --post_title="Block Post" --post_content="<!-- wp:paragraph --><p>Hello</p><!-- /wp:paragraph -->" --porcelain` |
There was a problem hiding this comment.
While this change to use double quotes for command arguments is correct for Windows compatibility, I've noticed that this fix has not been applied consistently throughout the file. There are other wp post create commands that still use single-quoted arguments containing spaces (e.g., on lines 1232, 1248). For complete Windows compatibility, all such instances should be updated to use double quotes.
No description provided.