refactor: streamline Stellar announcement fetching and add sdk-react …#99
Conversation
|
Close #53 |
|
@emarkees Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
The actual issue #53 work would be Stellar announcement streamlining + sdk-react. But this PR contains the exact same agent-generated cruft files we've been clearing out of #95 and #97:
git rm BENCHMARK_IMPLEMENTATION.md CONTEXT_BENCHMARKS_COMPLETE.md
git rm -r bench/ examples/react-native-stellar/
git rm docs/fee-estimation.md
git rm .github/workflows/benchmark.yml
git commit --amend --no-edit
git push --force-with-leaseOnce those are gone, the actual streamlining + sdk-react work can land. |
c025f9f to
6c64b06
Compare
6c64b06 to
3270b0d
Compare
|
Hey @emarkees — quick correction on my prior feedback. Since #97 landed, develop now has the Updated cleanup: git fetch origin
git rebase origin/develop
# in examples/react-native-stellar/*: take develop's version (don't delete)
# Still drop these (they ARE leftover agent cruft):
git rm BENCHMARK_IMPLEMENTATION.md CONTEXT_BENCHMARKS_COMPLETE.md
git rm -r bench/
git rm docs/fee-estimation.md
git rm .github/workflows/benchmark.yml
git rm src/chains/stellar/fee-estimation.ts test/chains/stellar/fee-estimation.test.ts test/chains/stellar/bench/stellar.bench.ts
# For src/chains/stellar/announcements.ts and src/chains/stellar/index.ts:
# keep develop's version (it has the audit fixes from #93) and re-apply your refactor on top
git rebase --continue
git push --force-with-leaseSorry for the back-and-forth. |
3270b0d to
d749faf
Compare
There was a problem hiding this comment.
@truthixify kindly check for a review, Correction has been made on request
2d8e940 to
4afefea
Compare
Atomic transaction that swaps fromAsset → toAsset via pathPaymentStrictReceive and delivers the output to a one-time stealth address, with an on-chain announcement in the same envelope. - Native XLM toAsset: 2 ops (pathPayment directly to stealth + announce) - Non-native toAsset: 3 ops (pathPayment to sender + claimableBalance + announce) - sendMax provides configurable slippage protection - Exports: buildStellarSwapAndStealth, BuildStellarSwapAndStealthOptions, SwapAndStealthResult - Unit tests (7) and integration tests (3, INTEGRATION=1 gated) - Docs: docs/guides/stellar-swap-and-stealth.mdx
4afefea to
836a5c9
Compare
|
@truthixify you can now merge as conflicts has been resolved |
|
Cruft cleaned, rebased. The actual work — sdk-react package + hooks + react-stellar-app example — looks good. Thanks for sticking with the cleanup, @emarkees. |
Closes #53
🚀 Description
This PR introduces the new @wraith-protocol/sdk-react companion hooks package, providing standardized React 18+ integrations to prevent integrators from writing repetitive useState/useEffect glue. It also includes fixes for underlying SDK bugs discovered during integration, and ships with a working example application.
📦 Features & Scope
New Workspace Package:
Core Hooks Implemented:
Testing & Build Pipeline: Fully configured vitest with jsdom testing environments.