Add aggregate strategies support (lateral & grouped)#1
Draft
wtsnz wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
Ultimately this came out of my last pr to ash_sqlite that adds aggregate support. After talking to Zach he brought up the idea that the different aggregate strategies should probably live in ash_sql instead of specifically inside of ash_sqlite. SQLite doesn't support aggregates based on lateral queries so instead we must implement a different strategy based on windows.
Two possible approaches going forward 1 OR 2:
a. Add support for Aggregates ash-project/ash_sqlite#213
a. This PR that adds the multiple aggregate strategies to ash_sql
b. A PR that adds the consumption of the above into ash_sqlite Add Aggregate Support using ash_sql implementation ash_sqlite#5
c. A tiny pr to ash_postgres that explicitly states the aggregate_strategy (wtsnz/ash_postgres@c02e86f)
The direction depends on what ash community want - I'll defer to them after asking