feat(ui): add closable Tag support#96
Merged
Merged
Conversation
Contributor
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closable,closeIcon,closeAriaLabel, andonClosesupport toTag, aligning with mature Tag APIs.event.preventDefault()inonCloseto keep the tag visible for confirmation or controlled removal flows.Validation
28911208037passed for commit6f2b6c84345114c2b773371fe4612ecb49cdf16d.npm run lint:ui,npm run typecheck:ui,npm run test:ui, andnpm run buildcould not be executed because the local shell runner failed to create a process in this Codex environment.