fix(2-bm): move AlignmentCamera to the 2-BM-A conditioning-optics group#297
Merged
Conversation
The AlignmentCamera is an A-station device (pv 2bma:m21, "A-station beam-view camera") but was sitting in the beam-defining-and-safety group, whose enclosure is 2-BM-B, so it was being reported as located in the experiment hutch. Moved it to conditioning-optics (enclosure 2-BM-A), where the rest of the A-station optics chain lives, matching its intended placement (ALIGN-1). This is the enclosure mis-grouping flagged as a fix-later during the PIEZO-1 work. The Aperture (the device originally noted) turned out to be correctly placed: it is a 2-BM-B device (z=51300) in the 2-BM-B group; the #285 rebase that landed both devices after BeamPositionMonitor fixed the Aperture's enclosure as a side effect but mis-placed the AlignmentCamera, which this corrects. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enclosure mis-grouping fix flagged as a fix-later during the PIEZO-1 work.
What
The
AlignmentCamerais an A-station device (pv: 2bma:m21, "A-station beam-view camera") but sat in thebeam-defining-and-safetygroup, whoseenclosureis 2-BM-B — so it was being reported as located in the experiment hutch. Moved it toconditioning-optics(2-BM-A), where the rest of the A-station optics chain lives, matching its intended placement (ALIGN-1).Note on the original flag
The device originally noted (the
Aperture) turned out to be correctly placed: it's a 2-BM-B device (z=51300) in the 2-BM-B group. The #285 rebase landed both the Aperture and the AlignmentCamera afterBeamPositionMonitor, which fixed the Aperture's enclosure as a side effect but mis-placed the AlignmentCamera — this corrects that.Pure descriptor move (15 lines out of one group, 15 into another).
tests/unit/deployments/(62) +mkdocs --strictclean.🤖 Generated with Claude Code