docs(2-bm): fold the vibration answers, drop the one-off baseline stubs (VIB-1..7)#299
Merged
Conversation
…bs (VIB-1..7) Staff settled the vibration / flat-field-stability questions (VIB-1 #265, VIB-2..7 #267): - VIB-1: the vibration measurement uses the SAME physical FLIR Oryx (serial 19173710) as the microscope camera 0, run in a high-frame-rate mode (~99 fps, 1000-frame stream), not separate hardware. Recorded as a note on the Camera descriptor entry. - VIB-2..7: the February 2026 vibration study (item_070) was a one-off, inconclusive investigation with no standing gates (the 100 mA value was incidental, no dominant source found, no calibrated flat-timing window). So CORA drops the Pending vibration_baseline Practice stub (deployments/aps/site.yaml) and the never-built vibration_baseline kind carve-out (test_procedure_kind_naming.py); no vibration Procedure or Caution is modeled. Removes the now-resolved "Vibration and beam stability" section from the 2-BM open-questions page (its table was already empty). Closes VIB-1 (#265) and VIB-2 through VIB-7 (#267). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Coverage report
This PR does not seem to contain any modification to coverable code. |
This was referenced Jun 22, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentary fold of the vibration / flat-field-stability staff answers.
What
Cameradescriptor entry.item_070) was a one-off investigation #267) — the Feb 2026 vibration study (item_070) was a one-off, inconclusive investigation with no standing gates (the 100 mA value was incidental, no dominant source found, no calibrated flat-timing window). So CORA drops the Pendingvibration_baselinePractice stub (deployments/aps/site.yaml) and the never-builtvibration_baselinekind carve-out (test_procedure_kind_naming.py); no vibration Procedure or Caution is modeled.Removes the now-resolved "Vibration and beam stability" section from the open-questions page (its table was already empty).
Note on scope
The assessment had also floated #245 PIEZO-5 as a documentary fold, but its buffer facts (1024/256/random) are already in the
ApertureFineDrivenote, and its only open part — the out2/out3→axis cable map — is explicitly operator-blocked (needs physical cable tracing). So #245 stays open with nothing to fold now.Tests
tests/unit/deployments/(62) +test_procedure_kind_naming.py+mkdocs --strictall green.Closes VIB-1 (#265) and VIB-2 through VIB-7 (#267).
🤖 Generated with Claude Code