Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Feature / Add edit in customizer buttons #140

Open
stuartshields wants to merge 26 commits into
base: develop
Choose a base branch
from
Open

Feature / Add edit in customizer buttons #140

Changes from 4 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
d0c02da
Move customize_url into own function
May 15, 2016
d35ffc6
feature/addeditincustomizerbuttons Initial concept
May 18, 2016
984b7cd
feature/addeditincustomizerbuttons Fix travis build issues
May 18, 2016
dca990b
feature/addeditincustomizerbuttons Fix last travis issue
May 18, 2016
3bb9949
feature/addeditincustomizerbuttons Start refactoring code
May 20, 2016
d18fb24
feature/addeditincustomizerbuttons Check if is defined
May 20, 2016
8011d97
feature/addeditincustomizerbuttons Fix travis issue with comment
May 20, 2016
b54051e
feature/addeditincustomizerbuttons Add to get_customize_url on posts…
May 20, 2016
1ae5186
feature/addeditincustomizerbuttons Restrict button to certain sections
May 20, 2016
ddeb2ff
feature/addeditincustomizerbuttons Check if Post or Page
May 20, 2016
b0e2f20
feature/addeditincustomizerbuttons Remove previewed_post from URL
May 25, 2016
2d54429
Merge branch 'develop' into feature/addeditincustomizerbuttons
May 25, 2016
d39dfd1
feature/addeditincustomizerbuttons Add permalink to get_preview_post_…
May 26, 2016
a335d32
feature/addeditincustomizerbuttons Be more consistant with code
May 26, 2016
e535780
feature/addeditincustomizerbuttons Use get_preview_post_link with pos…
May 26, 2016
9cb8cb6
feature/addeditincustomizerbuttons Add instanceof to get_customize_url
May 26, 2016
f7e53ff
Merge pull request #179 from xwp/release/0.6.1
valendesigns Jun 16, 2016
986c7f4
Ensure that plugin-support and theme-support are included in build
westonruter Jun 18, 2016
d41a4f6
Remove unrecognized Text Domain readme meta
westonruter Jun 18, 2016
e0589bc
Merge pull request #184 from xwp/bugfix/release-0.6.1
westonruter Jun 18, 2016
1ba5017
Fix location of readme change
westonruter Jun 18, 2016
bfdb6c7
Merge pull request #185 from xwp/bugfix/readme-0.6.1
westonruter Jun 18, 2016
04d19b9
Merge master & resolve conflicts
valendesigns Jun 19, 2016
3ab205a
This plugin is not namespaced
valendesigns Jun 19, 2016
f981ad5
Merge branch 'develop' into feature/addeditincustomizerbuttons
valendesigns Jun 19, 2016
3e5b3f9
Remove type hint
valendesigns Jun 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 52 additions & 7 deletions php/class-edit-post-preview.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ public function __construct( Customize_Posts_Plugin $plugin ) {
add_action( 'customize_controls_init', array( $this, 'remove_static_controls_and_sections' ), 100 );
add_action( 'customize_controls_enqueue_scripts', array( $this, 'enqueue_customize_scripts' ) );
add_action( 'customize_preview_init', array( $this, 'make_auto_draft_status_previewable' ) );
add_filter( 'post_row_actions', array( $this, 'add_edit_customizer_to_row_actions' ), 10, 2 );
add_filter( 'page_row_actions', array( $this, 'add_edit_customizer_to_row_actions' ), 10, 2 );
Copy link
Copy Markdown
Contributor

@westonruter westonruter May 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably loop over all post types that are are eligible for showing in the Customizer instead of hard-coding just two. There is a method for getting all post types and code in the plugin for determining if the post type should show_in_customizer

}

/**
Expand Down Expand Up @@ -101,7 +103,54 @@ public function enqueue_admin_scripts() {
return;
}
wp_enqueue_script( 'edit-post-preview-admin' );
$post = $this->get_previewed_post();
$customize_url = self::get_customize_url();

$data = array(
'customize_url' => $customize_url,
);

wp_scripts()->add_data( 'edit-post-preview-admin', 'data', sprintf( 'var _editPostPreviewAdminExports = %s;', wp_json_encode( $data ) ) );
wp_enqueue_script( 'customize-loader' );
wp_add_inline_script( 'edit-post-preview-admin', 'jQuery( function() { EditPostPreviewAdmin.init(); } );', 'after' );

if ( 'add' !== get_current_screen()->action ) {
wp_add_inline_script( 'edit-post-preview-admin', 'jQuery( \'.wrap h1\' ).append( \'<a class="page-title-action hide-if-no-customize" href="' . esc_url( $customize_url ) . '">Edit in Customizer</a>\' )', 'after' );
Copy link
Copy Markdown
Contributor

@westonruter westonruter May 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest adding the link in the footer, and then use jQuery to move this existing link in the document into the right place, instead putting the markup into a JS string.

Also needs translation function.

}
}

/**
* Add the edit customizer to row actions for Posts/Pages.
*
* @param array $actions Actions.
* @param object $post Post.
* @return array $rebuild_actions
*/
public function add_edit_customizer_to_row_actions( $actions, $post ) {
if ( ! is_a( $post, 'WP_Post' ) ) {
Copy link
Copy Markdown
Contributor

@valendesigns valendesigns May 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be consistent and use the same coding style. Other places in the plugin we would check if $post is an instance of WP_Post like this:

if ( ! ( $post instanceof WP_Post ) ) {
    return false;
}

Copy link
Copy Markdown
Author

@stuartshields stuartshields May 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valendesigns Thanks I've now fixed it.

return false;
}

// Let's rebuild the order of $actions.
$rebuild_actions = array();
$rebuild_actions['edit'] = $actions['edit'];
$rebuild_actions['edit_customizer'] = '<a href="' . esc_html( self::get_customize_url( $post ) ) . '">Edit in Customizer</a>';
Copy link
Copy Markdown
Contributor

@westonruter westonruter May 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esc_url() instead of esc_html()

Also, use esc_html__( 'Edit in Customizer', 'customize-posts' )

$rebuild_actions['inline hide-if-no-js'] = $actions['inline hide-if-no-js'];
$rebuild_actions['trash'] = $actions['trash'];
$rebuild_actions['view'] = $actions['view'];
Copy link
Copy Markdown
Contributor

@westonruter westonruter May 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other plugins that add action links? I think an array_merge() is required.

Copy link
Copy Markdown
Author

@stuartshields stuartshields May 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter definitely.


return $rebuild_actions;
}

/**
* Get the customize line
*
* @param array $post Post.
* @return string $customize_url
*/
public function get_customize_url( $post = null ) {
if ( ! is_a( $post, 'WP_Post' ) ) {
Copy link
Copy Markdown
Contributor

@valendesigns valendesigns May 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one could also be updated.

$post = $this->get_previewed_post();
}

$id_param = ( 'page' === $post->post_type ) ? 'page_id' : 'p';
$url = get_preview_post_link( $post, array(), home_url( '?preview=true&' . $id_param . '=' . $post->ID ) );
Expand All @@ -114,12 +163,8 @@ public function enqueue_admin_scripts() {
),
wp_customize_url()
);
$data = array(
'customize_url' => $customize_url,
);
wp_scripts()->add_data( 'edit-post-preview-admin', 'data', sprintf( 'var _editPostPreviewAdminExports = %s;', wp_json_encode( $data ) ) );
wp_enqueue_script( 'customize-loader' );
wp_add_inline_script( 'edit-post-preview-admin', 'jQuery( function() { EditPostPreviewAdmin.init(); } );', 'after' );

return $customize_url;
}

/**
Expand Down