fix: Node 25.7+ EBADF by reading CJS source of zip files#7070
Open
NormalGaussian wants to merge 1 commit intoyarnpkg:masterfrom
Open
fix: Node 25.7+ EBADF by reading CJS source of zip files#7070NormalGaussian wants to merge 1 commit intoyarnpkg:masterfrom
NormalGaussian wants to merge 1 commit intoyarnpkg:masterfrom
Conversation
NormalGaussian
force-pushed
the
fix/ebadf-bypass-25.7.x
branch
from
82edc82 to
37d1f56
Compare
NormalGaussian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix the EBADF encountered due to patching fs by doing the whole read instead.
I did this to get my own changes past a client (i.e. convincing them it isn't me that is the issue); I'm not sure this is the right long term choice.
What's the problem this PR addresses?
#7065
Can't load zipped CJS modules in Node 25.7+
How did you fix it?
Return the source of zipped files instead of letting Node read it. I basically just went off this comment: nodejs/node#62012 (comment)
I'm not certain this is the most desirable way to do this, and if it is I'm not sure if there are other places that will need additional fixes. My knowledge of the codebase makes this an uneasy 'this works for me' solution. I suspect that if it is a reasonable solution, there may be some deletion that can be done.
Checklist