WHIR no-epoch (prove-and-retire) prover: block 25368371 — work in progress

.github/workflows/benchmark-pr.yml

@@ -64,14 +64,15 @@ env:
   # from one real one. Only the headline screen was dropped.
   #
   # Cycle counts below are for the ELF THIS JOB BUILDS (see "Build ethrex guest ELF"),
-  # as of main @ 9ccdaf2 with clang 21. They move with guest optimisation (#861 gave the
-  # guest thin LTO) and ~2% with the clang major on PATH, so a count quoted against a
+  # as of the guest built with fat LTO and its own memcpy. They move with guest
+  # optimisation (#861 gave the guest thin LTO, fat LTO and the runtime memcpy took
+  # another 20 %) and ~2% with the clang major on PATH, so a count quoted against a
   # different ELF reads as a regression — always pin the ELF when repeating one.
   ELF: executor/program_artifacts/rust/ethrex.elf
   # The workload: a real Ethereum block. WHICH block lives in
   # the Makefile and nowhere else — nothing in this file names one, so a repoint
   # moves this job without editing it. At the current default and pinned ethrex rev that
-  # is 30,498,818 cycles, 10,659 keccak calls and 116 ecsm calls — several times the work
+  # is 23,935,913 cycles, 10,659 keccak calls and 116 ecsm calls — several times the work
   # of the synthetic block, at a very different keccak:ecrecover mix. That is the whole
   # point: a prover change can move the synthetic number and the real one in opposite
   # directions. All three figures move with the ethrex rev, so re-measure on a bump

.github/workflows/pr_main.yaml

@@ -96,14 +96,20 @@ jobs:
         run: |
           make compile-programs-asm
 
+      # The key hashes every source a Rust guest build reads: the guest crates, the guest
+      # runtime (syscalls), the crypto crates guests depend on by path (ethrex-crypto for the
+      # ethrex guest; crypto and math for keccak_transcript_pattern), the target spec and the
+      # Makefile's recipe. An exact hit skips the compile step below, so a change confined to
+      # one of them that the key missed would run every test on a stale ELF. The same key
+      # appears in each job that restores these ELFs.
       - name: Cache compiled Rust ELF artifacts and build cache
         id: cache-rust-elfs
         uses: actions/cache@v4
         with:
           path: |
             executor/program_artifacts/rust
             executor/shared_target
-          key: rust-elf-artifacts-${{ hashFiles('executor/programs/rust/**', 'executor/programs/riscv64im-lambda-vm-elf.json', 'syscalls/**', 'Makefile') }}
+          key: rust-elf-artifacts-${{ hashFiles('executor/programs/rust/**', 'executor/programs/riscv64im-lambda-vm-elf.json', 'syscalls/**', 'crypto/ethrex-crypto/src/**', 'crypto/ethrex-crypto/Cargo.toml', 'crypto/crypto/src/**', 'crypto/crypto/Cargo.toml', 'crypto/math/src/**', 'crypto/math/Cargo.toml', 'Makefile') }}
           restore-keys: |
             rust-elf-artifacts-
 
@@ -198,10 +204,53 @@ jobs:
 
   # "Test" is a required check — keep this name to avoid branch protection changes.
   # This gate job passes only when CLI, executor, disk-spill, and prover tests succeed.
+  host-kat:
+    # The device kernels' known-answer gates. `make test-*-host-kat` compiles the
+    # REAL `.cu` sources as host C++ through
+    # `crypto/math-cuda/tests/host_kat/cuda_host_shim.h` and runs them against
+    # external vectors (the official BLAKE3 vectors, miden-crypto's RPO vectors)
+    # and the committed oracle tables — g++ only, no CUDA, no cargo, seconds. It
+    # is the only per-PR check on the kernel arithmetic: the GPU parity suites
+    # (gpu-tests.yml) run on merge_group alone, and until this job existed the
+    # host-KAT targets lived in no workflow at all. Arithmetic only — nvcc
+    # acceptance and everything about execution stay with the GPU tests.
+    name: Host KAT (kernel pins)
+    runs-on: ubuntu-latest
+    if: github.event_name != 'push' || github.actor != 'github-merge-queue[bot]'
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@v4
+
+      - name: BLAKE3 host-KAT (7-round and 6-round arms)
+        run: make test-blake3-host-kat
+
+      - name: RPX host-KAT (permutation, leaf sponge, parent, leaf and tree kernels)
+        run: make test-rpx-host-kat
+
+      - name: Column-major LDE engine host-KAT (NTT passes, coset LDE)
+        run: make test-ntt-cm-host-kat
+
+      - name: WHIR host-KAT (fused round fold, lean first rounds)
+        run: make test-whir-host-kat
+
+      - name: GKR host-KAT (layer rounds over an input layer kept without its padding)
+        run: make test-gkr-host-kat
+
+      - name: Round-slot host-KAT (a round's sums reduced by its last block)
+        run: make test-round-slot-host-kat
+
+      # Second source for the TABLES the BLAKE3 host-KAT trusts: upstream
+      # BLAKE3's portable C with its round loop parameterised, against the
+      # committed 6-round vectors and the Python oracle. A ~1 s C compile plus a
+      # few seconds of Python (cc + python3, both on the runner); it too had no
+      # workflow before this job.
+      - name: BLAKE3 second-source check of the 6-round tables
+        run: make test-blake3-second-source
+
   test:
     name: Test
     if: always()
-    needs: [test-executor, test-cli, test-prover, test-disk-spill, test-stark-cuda-lib]
+    needs: [test-executor, test-cli, test-prover, test-disk-spill, test-stark-cuda-lib, host-kat]
     runs-on: ubuntu-latest
     steps:
       - name: Check results
@@ -211,12 +260,14 @@ jobs:
           prover="${{ needs.test-prover.result }}"
           disk_spill="${{ needs.test-disk-spill.result }}"
           stark_cuda_lib="${{ needs.test-stark-cuda-lib.result }}"
+          host_kat="${{ needs.host-kat.result }}"
 
           echo "test-executor: $executor"
           echo "test-cli: $cli"
           echo "test-prover: $prover"
           echo "test-disk-spill: $disk_spill"
           echo "test-stark-cuda-lib: $stark_cuda_lib"
+          echo "host-kat: $host_kat"
 
           # Allow "success" or "skipped" (skipped on merge queue pushes)
           if [[ "$executor" != "success" && "$executor" != "skipped" ]]; then
@@ -234,6 +285,9 @@ jobs:
           if [[ "$stark_cuda_lib" != "success" && "$stark_cuda_lib" != "skipped" ]]; then
             exit 1
           fi
+          if [[ "$host_kat" != "success" && "$host_kat" != "skipped" ]]; then
+            exit 1
+          fi
 
   test-disk-spill:
     name: Disk-spill tests
@@ -275,7 +329,7 @@ jobs:
           path: |
             executor/program_artifacts/rust
             executor/shared_target
-          key: rust-elf-artifacts-${{ hashFiles('executor/programs/rust/**', 'executor/programs/riscv64im-lambda-vm-elf.json', 'syscalls/**', 'Makefile') }}
+          key: rust-elf-artifacts-${{ hashFiles('executor/programs/rust/**', 'executor/programs/riscv64im-lambda-vm-elf.json', 'syscalls/**', 'crypto/ethrex-crypto/src/**', 'crypto/ethrex-crypto/Cargo.toml', 'crypto/crypto/src/**', 'crypto/crypto/Cargo.toml', 'crypto/math/src/**', 'crypto/math/Cargo.toml', 'Makefile') }}
           restore-keys: |
             rust-elf-artifacts-
 
@@ -391,7 +445,7 @@ jobs:
           path: |
             executor/program_artifacts/rust
             executor/shared_target
-          key: rust-elf-artifacts-${{ hashFiles('executor/programs/rust/**', 'executor/programs/riscv64im-lambda-vm-elf.json', 'syscalls/**', 'Makefile') }}
+          key: rust-elf-artifacts-${{ hashFiles('executor/programs/rust/**', 'executor/programs/riscv64im-lambda-vm-elf.json', 'syscalls/**', 'crypto/ethrex-crypto/src/**', 'crypto/ethrex-crypto/Cargo.toml', 'crypto/crypto/src/**', 'crypto/crypto/Cargo.toml', 'crypto/math/src/**', 'crypto/math/Cargo.toml', 'Makefile') }}
           restore-keys: |
             rust-elf-artifacts-
 
@@ -480,7 +534,7 @@ jobs:
           path: |
             executor/program_artifacts/rust
             executor/shared_target
-          key: rust-elf-artifacts-${{ hashFiles('executor/programs/rust/**', 'executor/programs/riscv64im-lambda-vm-elf.json', 'syscalls/**', 'Makefile') }}
+          key: rust-elf-artifacts-${{ hashFiles('executor/programs/rust/**', 'executor/programs/riscv64im-lambda-vm-elf.json', 'syscalls/**', 'crypto/ethrex-crypto/src/**', 'crypto/ethrex-crypto/Cargo.toml', 'crypto/crypto/src/**', 'crypto/crypto/Cargo.toml', 'crypto/math/src/**', 'crypto/math/Cargo.toml', 'Makefile') }}
           restore-keys: |
             rust-elf-artifacts-
 
@@ -564,7 +618,7 @@ jobs:
           path: |
             executor/program_artifacts/rust
             executor/shared_target
-          key: rust-elf-artifacts-${{ hashFiles('executor/programs/rust/**', 'executor/programs/riscv64im-lambda-vm-elf.json', 'syscalls/**', 'Makefile') }}
+          key: rust-elf-artifacts-${{ hashFiles('executor/programs/rust/**', 'executor/programs/riscv64im-lambda-vm-elf.json', 'syscalls/**', 'crypto/ethrex-crypto/src/**', 'crypto/ethrex-crypto/Cargo.toml', 'crypto/crypto/src/**', 'crypto/crypto/Cargo.toml', 'crypto/math/src/**', 'crypto/math/Cargo.toml', 'Makefile') }}
           restore-keys: |
             rust-elf-artifacts-
 

Cargo.toml

@@ -7,6 +7,7 @@ members = [
   "crypto/ecsm",
   "crypto/math",
   "crypto/math-cuda",
+  "crypto/multilinear",
   "bin/cli",
 ]
 # Riscv-only bare-metal crate, path-dependent from crypto/crypto (target-gated),