Repository navigation
Correct comments and test data left stale by the COPY unification - #1028
Merged
Merged
Conversation
- Name COPY (not COMMIT) among the ECALL receivers and as the Commit-bus sender. - Count five accelerators, not six, and rename the test that says six. - logs.rs: the row width follows from the count alone; it no longer reads src % 8 / dst % 8. - CLI accel_counts_sizes_dma_calls: derive rows with copy_trace_rows instead of the old terminal-row schedule. - Drop the doubled #[cfg(test)], the DMA/DMA_SET history line, the stale drift-test doc, the allocator and dma_memset_min comments.
|
Benchmark Results for modified programs 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #984. Comments and test data only; no logic changes.
types.rs,cpu.rs,keccak.rs,hint.rs) and in the executor's public-output docs (memory.rs,executor/tests/rust.rs,prove_elfs_tests.rs).lib.rs,skip_empty_tables_tests.rs, test renamed toa_run_without_accelerators_omits_all_five).logs.rs: the row width follows from the count alone; it no longer readssrc % 8/dst % 8.accel_counts_sizes_dma_calls: rows come fromcopy_trace_rowsinstead of the old terminal-row schedule ((256, 33)→ 32 rows).#[cfg(test)], the DMA/DMA_SET history line incopy.rs, and update the drift-test doc, theallocator.rsnote and thedma_memset_mincomment.make fmtandmake lintpass;cargo test -p cli accel_counts_sizes_dma_callspasses.