Skip to content

feat: add comingSoon support to HoursStatus and HoursTable#1222

Merged
asanehisa merged 5 commits into
2026-custom-components-templatesfrom
coming-soon
May 29, 2026
Merged

feat: add comingSoon support to HoursStatus and HoursTable#1222
asanehisa merged 5 commits into
2026-custom-components-templatesfrom
coming-soon

Conversation

@asanehisa
Copy link
Copy Markdown
Contributor

@asanehisa asanehisa commented May 29, 2026

https://www.yext.com/s/4412098/yextsites/157360/pagesets
Screenshot 2026-05-29 at 11 50 44 AM
Screenshot 2026-05-29 at 11 49 37 AM
Screenshot 2026-05-29 at 1 39 12 PM

There is discussion getting comingSoon in the search results for Locator, but confirmed if I put comingSoon in the search results (hardcoded), the Locator Result Card's HoursTable adjusts according.

@github-actions
Copy link
Copy Markdown
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Review Change Stack

Warning

Review limit reached

@asanehisa, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 57 minutes and 53 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2e3d00b5-ed74-482a-abcf-1dcc5b46c45f

📥 Commits

Reviewing files that changed from the base of the PR and between 81ceece and e1f2466.

📒 Files selected for processing (3)
  • packages/visual-editor/src/components/LocatorResultCard.tsx
  • packages/visual-editor/src/components/contentBlocks/HoursStatus.tsx
  • packages/visual-editor/src/components/contentBlocks/HoursTable.tsx

Walkthrough

This PR introduces comprehensive support for displaying a "Coming Soon" status when business hours data is not yet available. The change spans localization (48 new locale strings across 24 languages in component and platform files), type system updates to thread the new field through location data models, rendering logic in hours atoms to conditionally display "Coming Soon" instead of hours data, content block updates that treat coming-soon as a valid render state alongside actual hours, and card-level integration to surface the field from location sources. The @yext/pages-components dependency is also bumped from ^2.1.0 to ^2.2.0.

Possibly related PRs

  • yext/visual-editor#1155: Modifies LocatorResultCard's HoursSection ARIA attributes and expansion logic, which is in the same component where this PR adds coming-soon rendering state.
  • yext/visual-editor#1121: Updates HoursStatusProps.parentData and HoursStatusWrapper logic in the same component where this PR adds coming-soon state handling.
  • yext/visual-editor#918: Also bumps @yext/pages-components version in packages/visual-editor/package.json and starter/package.json.

Suggested labels

create-dev-release

Suggested reviewers

  • mkilpatrick
  • briantstephan
  • jwartofsky-yext
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author; the description field is empty. Add a pull request description explaining the purpose, implementation details, and rationale for adding comingSoon support to hours components.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding 'comingSoon' support to HoursStatus and HoursTable components.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch coming-soon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asanehisa asanehisa added the create-dev-release Triggers dev release workflow label May 29, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 29, 2026

commit: e1f2466

@asanehisa asanehisa marked this pull request as ready for review May 29, 2026 18:17
mkilpatrick
mkilpatrick previously approved these changes May 29, 2026
Comment thread packages/visual-editor/src/components/contentBlocks/HoursStatus.tsx Outdated
Comment thread packages/visual-editor/src/components/contentBlocks/HoursTable.tsx Outdated
Comment thread packages/visual-editor/src/components/LocatorResultCard.tsx Outdated
@asanehisa asanehisa requested review from benlife5 and mkilpatrick May 29, 2026 19:40
@asanehisa asanehisa merged commit 21e4a8f into 2026-custom-components-templates May 29, 2026
18 checks passed
@asanehisa asanehisa deleted the coming-soon branch May 29, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-dev-release Triggers dev release workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants