Add locales mapping for gettext#76
Open
darkdef wants to merge 33 commits into
Open
Conversation
darkdef
commented
Apr 20, 2025
darkdef
commented
Contributor
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Fixed issues | #73 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 9 10 +1
===========================================
Files 1 1
Lines 18 21 +3
===========================================
+ Hits 18 21 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Looks 👍 Would you please update docs? |
vjik
requested changes
Apr 28, 2025
| public function __construct( | ||
| private string $path | ||
| private string $path, | ||
| private array|Closure|null $localesMap = null |
| private function setLocale(string $locale): void | ||
| { | ||
| if ($this->localesMap instanceof Closure) { | ||
| $locale = (string) ($this->localesMap)($locale); |
Member
There was a problem hiding this comment.
Allow to return null in closure and use $locale as is in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.