Skip to content

Dev nodejs 24 #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoavnir merged 6 commits into from
Jun 16, 2026
+31 −29
Merged

Dev nodejs 24 #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
777075f
Issue #412 - Start branch for Nodejs 24 transition
Jun 4, 2026
29af95a
Issue #412 - force nodejs 24
Jun 4, 2026
7b042b8
Also msbuild
Jun 4, 2026
f69e810
Issue #412 - update upload-artifact action to v7
Jun 4, 2026
7fccb65
Issue #412 - two more
Jun 4, 2026
7cc180b
Merge branch 'dev-1.0.0' into dev-nodejs-24
yoavnir Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions .github/workflows/c-cpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@ name: C/C++ CI

on:
push:
branches: [ dev, stable, dev-0.9.9, dev-1.0.0, dev-rolling-context]
branches: [ dev, stable, dev-0.9.9, dev-1.0.0, dev-nodejs-24]
pull_request:
branches: [ dev, stable, dev-0.9.9, dev-1.0.0, dev-rolling-context]
branches: [ dev, stable, dev-0.9.9, dev-1.0.0, dev-nodejs-24]

env:
SPECS_BRANCH: ${{ github.event.pull_request.base.ref || github.ref_name }}
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
SPECS_BUILD_SOURCE: github
SPECS_BUILD_RUNID: ${{ github.run_id }}
SPECS_BUILD_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
Expand All @@ -17,7 +18,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0

Expand All @@ -29,7 +30,7 @@ jobs:
echo "$PR_EVENT"

- name: Set up Python 3.12
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version: '3.12'

Expand All @@ -52,12 +53,12 @@ jobs:
runs-on: macos-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Set up Python 3.12
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version: '3.12'

Expand All @@ -80,12 +81,12 @@ jobs:
runs-on: windows-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Add MSBuild to PATH
uses: microsoft/setup-msbuild@v2
uses: microsoft/setup-msbuild@v3

- name: Build specs (Debug)
run: msbuild specs/specs.sln /p:Configuration=Debug /p:Platform=x64
Expand All @@ -100,17 +101,17 @@ jobs:
runs-on: windows-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Set up Python 3.12
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Add MSBuild to PATH
uses: microsoft/setup-msbuild@v2
uses: microsoft/setup-msbuild@v3

- name: Build specs with Python (Release)
run: msbuild specs/specs.sln /p:Configuration=Release /p:Platform=x64 /p:EnablePython=true
Expand Down
37 changes: 19 additions & 18 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ on:
env:
SPECS_VERSION: ${{ github.event.release.tag_name }}
SPECS_BRANCH: ${{ github.event.release.target_commitish }}
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
SPECS_BUILD_SOURCE: github
SPECS_BUILD_NUMBER: ${{ github.run_number }}
SPECS_BUILD_RUNID: ${{ github.run_id }}
Expand All @@ -28,7 +29,7 @@ jobs:
DEBIAN_FRONTEND=noninteractive apt-get update
DEBIAN_FRONTEND=noninteractive apt-get install -y git

- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0

Expand Down Expand Up @@ -108,20 +109,20 @@ jobs:
rpmbuild --define "_topdir $(pwd)/rpmbuild" -bb rpmbuild/SPECS/specs.spec

- name: Upload RPM artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: linux-rpm
path: rpmbuild/RPMS/**/*.rpm

build-macos:
runs-on: macos-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Set up Python 3.12
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version: '3.12'

Expand Down Expand Up @@ -174,20 +175,20 @@ jobs:
specs-${SPECS_VERSION#v}.pkg

- name: Upload pkg artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: macos-pkg
path: specs-*.pkg

build-windows:
runs-on: windows-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Add MSBuild to PATH
uses: microsoft/setup-msbuild@v2
uses: microsoft/setup-msbuild@v3

- name: Normalize Windows version metadata
id: version
Expand Down Expand Up @@ -249,31 +250,31 @@ jobs:
run: wix build -o specs-${{ steps.version.outputs.display }}.msi specs.wxs

- name: Upload MSI artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: windows-msi
path: specs-*.msi

- name: Upload standalone executable artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: windows-exe
path: specs-*-windows-x64.exe

build-windows-python:
runs-on: windows-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Set up Python 3.12
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Add MSBuild to PATH
uses: microsoft/setup-msbuild@v2
uses: microsoft/setup-msbuild@v3

- name: Normalize Windows version metadata
id: version
Expand Down Expand Up @@ -335,13 +336,13 @@ jobs:
run: wix build -o specs-${{ steps.version.outputs.display }}-python312.msi specs-python.wxs

- name: Upload MSI artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: windows-msi-python
path: specs-*-python312.msi

- name: Upload standalone executable artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: windows-exe-python
path: specs-*-python312-windows-x64.exe
Expand Down Expand Up @@ -369,7 +370,7 @@ jobs:
DEBIAN_FRONTEND=noninteractive $APT update
DEBIAN_FRONTEND=noninteractive $APT install -y git

- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0

Expand Down Expand Up @@ -446,7 +447,7 @@ jobs:
dpkg-deb --build deb-root specs_${SPECS_VERSION#v}_${{ matrix.arch }}.deb

- name: Upload DEB artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: linux-deb-${{ matrix.arch }}
path: specs_*.deb
Expand All @@ -458,15 +459,15 @@ jobs:
contents: write
steps:
- name: Download all artifacts
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
path: artifacts

- name: List artifacts
run: find artifacts -type f

- name: Upload release assets
uses: softprops/action-gh-release@v2
uses: softprops/action-gh-release@v3
with:
files: |
artifacts/linux-rpm/**/*.rpm
Expand Down