Refactor CSV processing and SQL generation#74
Open
theotrosman wants to merge 1 commit into
Open
Conversation
|
@theotrosman is attempting to deploy a commit to the zachpmanson Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the script that converts CSV data into SQL inserts.
The previous version worked, but it was a bit hard to follow, lots of nested with statements, manual string building, and some file pointer tricks to deal with trailing commas.
I refactored it to make things simpler and easier to read:
Split the logic into small functions (parsing, reading, SQL generation)
Got rid of the seek() workaround by using join
Reduced nesting so the flow is clearer
Improved naming so it’s easier to understand what’s going on
There are no changes to the actual output. it should generate the exact same SQL as before. This is just about making the code cleaner and easier to maintain going forward.