Repository navigation
fix(video-agent-kit): gate subtitle codecs by render mode - #121
Draft
Ricardo-M-L wants to merge 1 commit into
Draft
Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin type (required)
Affected plugin:
video-agent-kit.What
subtitle_render(mode="soft")copies the existing video/audio streams and encodes only amov_textsubtitle track, but its unconditional preflight requireslibx264,aac, and libass'ssubtitlesfilter. This rejects otherwise usable FFmpeg builds (including the local Homebrew FFmpeg 8.1 build without libass).Validate the mode first, then check the capabilities each actual command uses:
soft:mov_textencoder, no filters or media encoders.burn:libx264encoder andassfilter; audio remains stream-copied.both: the union of those requirements.This does not change the generated FFmpeg commands, authentication, network access, or existing output-file side effects. Both manifests and the marketplace entry advance from
0.4.3to0.4.4. No new dependencies or third-party code are introduced.Verified
python3 scripts/validate.py: all 51 plugins pass.build_zipimplementation successfully builds the changedvideo-agent-kitarchive.pnpm install --frozen-lockfileandgit diff --checkpass.Why this is a draft
The repository-wide packaging gate is not complete, so this PR is not requesting review:
pnpm buildrequires the entire UI-plugin catalog. After installing the pinned Rust 1.95.0 WASM target and checksum-verifying Trunk 0.21.14, Excalidraw and PhotoCraft built/staged successfully. VectorCraft passed its check build, but its optimized WASM build was stopped before completion to bound disk consumption. Remaining UI builds were not completed.python3 scripts/build_dist.pyrun fails withUnsafeTree: vectorcraft: incomplete build; run pnpm build first. The targeted ZIP is not a substitute for this full gate.tests/test_parallel_publish.pyimportsscripts/publish_incremental.py, which is absent on the base commit. This is not reported as a passing suite.README.mdand noREADME_CN.mdon the base. Its existing README was updated; a repository-wide documentation migration is not included.Self-check
marketplace.json.build_dist.pygate and real ZCode host verification complete.AI-assisted implementation and tests, independently reviewed with a separate rerun of the focused real-FFmpeg tests. Remaining gates are deliberately left visible before requesting maintainer review.