-
-
Notifications
You must be signed in to change notification settings - Fork 399
chore: add zizmor to repo checks #3837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
aeced63
9f11681
6cef1cd
bee023e
c628827
0abeb1b
7e094d5
76cf03c
728fc14
345ee4c
f0f67bc
be84ea6
5a975fd
e55c956
5dd3a3f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,24 @@ | ||
| name: "Pull Request Labeler" | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| # pull_request_target is needed to label PRs from forks. | ||
| # This workflow only runs actions/labeler (no code checkout), so it's safe. | ||
|
Comment on lines
+4
to
+5
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just to note, the permissions in this workflow do not distinguish between writing code and labels, it's just a "write" permission. We could rethink the value of this labeler vs. a pre-release check for meaningful release notes for every commit if we want to be extra safe, or just leave this. |
||
| pull_request_target: # zizmor: ignore[dangerous-triggers] | ||
| types: [opened, reopened, synchronize] | ||
|
|
||
| permissions: {} | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| labeler: | ||
| if: ${{ github.event.pull_request.user.login != 'dependabot[bot]' }} && ${{ github.event.pull_request.user.login != 'pre-commit-ci[bot]' }} | ||
| name: Label pull request | ||
| if: ${{ github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.user.login != 'pre-commit-ci[bot]' }} | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| contents: read # Required to read label configuration | ||
| pull-requests: write # Required to add labels to PRs | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/labeler@634933edcd8ababfe52f92936142cc22ac488b1b # v6.0.1 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can have OIDC with codecov IIRC, which would work without a token. We can also use environments that do not need reviews. I just made the release env review-required because I thought it was a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #3837 (comment). I looked into setting up OIDC for codecov and I didn't get it 🙃 lmk if you know how it works.