chore: use coverage run instead of pytest --cov#3847
Open
maxrjones wants to merge 5 commits intozarr-developers:mainfrom
Open
chore: use coverage run instead of pytest --cov#3847maxrjones wants to merge 5 commits intozarr-developers:mainfrom
coverage run instead of pytest --cov#3847maxrjones wants to merge 5 commits intozarr-developers:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3847 +/- ##
===========================================
+ Coverage 62.13% 92.86% +30.73%
===========================================
Files 86 86
Lines 10630 10630
===========================================
+ Hits 6605 9872 +3267
+ Misses 4025 758 -3267 🚀 New features to boost your workflow:
|
…-time coverage The pytest11 entry point (`zarr = "zarr.testing"`) imports 76 zarr modules during plugin loading, before pytest-cov starts measuring. This caused all module-level code (class definitions, imports, decorators) to appear uncovered, dropping reported coverage well below actual test coverage. `coverage run -m pytest` starts tracing before any imports, resolving the issue.
coverage run instead of pytest --cov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pytest11 entry point (
zarr = "zarr.testing") imports 76 zarr modulesduring plugin loading, before pytest-cov starts measuring. This caused all
module-level code (class definitions, imports, decorators) to appear uncovered,
dropping reported coverage well below actual test coverage.
coverage run -m pyteststarts tracing before any imports, resolving the issue.Increases the codecov reported coverage from ~60% to >90%.
TODO:
docs/user-guide/*.mdchanges/