Skip to content

fix: reuse existing service by name instead of creating duplicates #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Raymondhou0917 wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −4
Open

fix: reuse existing service by name instead of creating duplicates #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions internal/cmd/deploy/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,27 @@ func runDeploy(f *cmdutil.Factory, opts *Options) error {
return err
}
} else {
// create a new service
service, err = f.ApiClient.CreateEmptyService(context.Background(), projectID, opts.name)
if err != nil {
return err
// check if a service with the same name already exists
if opts.name != "" {
existingServices, err := f.ApiClient.ListAllServices(context.Background(), projectID)
if err != nil {
return fmt.Errorf("listing services: %w", err)
}
for _, s := range existingServices {
if s.Name == opts.name {
service = s
f.Log.Infof("Found existing service '%s', redeploying...", opts.name)
break
}
}
}

// create a new service if no existing one was found
if service == nil {
service, err = f.ApiClient.CreateEmptyService(context.Background(), projectID, opts.name)
if err != nil {
return err
}
}
}

Expand Down