fix: correct pagination skip increment in ListAllProjects and ListAllTemplates#212
Merged
yuaanlin merged 1 commit intozeabur:mainfrom Apr 3, 2026
Merged
Conversation
…Templates Both functions request 100 items per page (limit=100) but advance the skip cursor by only 5 on each iteration: skip += 5 // should be skip += 100 This means pages 2+ always start at offset 5, 10, 15... instead of 100, 200, 300... causing the first 5 results to be fetched ~20 times and results 6-100 to never be returned on subsequent pages. Any user with more than 5 projects or templates would receive duplicate and incomplete results.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughTwo pagination functions have their step size increments updated from 5 to 100. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both
ListAllProjectsandListAllTemplatesuseskip += 5while requestinglimit=100items per page:This means:
Any user with more than 5 projects or templates gets heavily duplicated results, and items beyond position 5 on the second page are never returned.
Fix
Change
skip += 5toskip += 100in both functions so the offset advances by the actual page size.Files changed
pkg/api/project.go— 1-line fixpkg/api/template.go— 1-line fixSummary by CodeRabbit