soc: intel_adsp: Manage power gating based on core activity#89528
Merged
kartben merged 3 commits intozephyrproject-rtos:mainfrom Jun 6, 2025
Merged
Conversation
github-actions
Bot
requested review from
andyross,
ceolin,
dcpleung,
jxstelter,
kv2019i,
lgirdwood,
lyakh,
marcinszkudlinski,
nashif and
softwarecki
This patch enhances the power management capabilities of the Intel ADSP by ensuring that power gating states are appropriately managed based on core activity. It prevents the primary core from entering power gating if secondary cores are active and re-enables power gating when all secondary cores are off, using pm_policy_state_lock_get and pm_policy_state_lock_put functions. The Sound Open Firmware (SOF) project currently uses a custom power management policy to achieve these effects. With this patch, the default power management policy can be utilized, allowing the option to disable the custom policy while maintaining system reliability and performance across different core states. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
This patch makes cosmetic changes to ace/power.c by updating comments to Doxygen style, fixing typos, and removing an extraneous character for improved readability and consistency. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
Contributor
|
@tmleman Can you fix the |
kv2019i
previously approved these changes
May 6, 2025
| /* The primary core cannot enter power gating if any of the secondary cores are | ||
| * active. | ||
| */ | ||
| pm_policy_state_lock_get(PM_STATE_RUNTIME_IDLE, PM_ALL_SUBSTATES); |
Contributor
There was a problem hiding this comment.
So each secondary gets a lock reference and when the last gives up its reference, idle is allowed, right?
dcpleung
previously approved these changes
May 6, 2025
This patch makes cosmetic changes to cavs/power.c by updating comments to Doxygen style, fixing typos. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
Contributor
Author
|
SOF CI: thesofproject/sof#9992 |
dcpleung
approved these changes
May 7, 2025
serhiy-katsyuba-intel
approved these changes
Jun 5, 2025
marcinszkudlinski
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enhances the power management capabilities of the Intel ADSP by ensuring that power gating states are appropriately managed based on core activity. It prevents the primary core from entering power gating if secondary cores are active and re-enables power gating when all secondary cores are off, using
pm_policy_state_lock_getandpm_policy_state_lock_putfunctions.The Sound Open Firmware (SOF) project currently uses a custom power management policy to achieve these effects. With this patch, the default power management policy can be utilized, allowing the option to disable the custom policy while maintaining system reliability and performance across different core states.