π docs(adr): ADR consistency cleanup β numbering, nav, format, cross-refs#422
Merged
Conversation
β¦ame to 124 Two Accepted ADRs both claimed number 121 on main: - 121-native-sync-unasync.md (created first, referenced by CLAUDE.md) - 121-policy-rename-clarity.md (created later, amends ADR-117) Native-sync keeps 121 since it is the earlier file and is referenced externally (CLAUDE.md). Renumber the IAM policy-rename ADR to 124 (next free number after 123-local-secondary-indexes). This is a structural collision fix, not a decision change, so it is consistent with the ADR immutability rule. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sodre
added a commit
that referenced
this pull request
Jun 12, 2026
β¦β 124) This branch forked from main after both ADR-121 files existed, so it carried the same duplicate-121 collision. Apply the identical fix used on main (#422): rename policy-rename-clarity 121 β 124 so the branch is self-consistent and merges cleanly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ADR-121 (native-sync) used a `## Status` heading with the value on a separate line, unlike every other ADR which uses the `**Status:**` / `**Date:**` inline format mandated by ADR-000. Normalize it (Date taken from the file's creation commit, 2026-02-02). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The ADR nav stopped at ADR-113; ADRs 114-124 existed as files but were unreachable from the docs site. Add thematic groups (Composite Items, IAM Resources, Config Hierarchy & TTL, Sync & Repository, Pre-1.0 Hardening) covering 114-124, reflecting the corrected numbering (121=native-sync, 124=policy-rename). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Reportβ
All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
===========================================
- Coverage 92.38% 29.14% -63.25%
===========================================
Files 37 37
Lines 7854 7854
===========================================
- Hits 7256 2289 -4967
- Misses 598 5565 +4967
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Harness. |
Surfaced by the /adr consistency audit: - ADR-107: annotate the partial supersession by ADR-117. Two Accepted ADRs asserted opposite IAM defaults (roles-by-default vs policies-by- default). Flag it in the status line and add a Decision note pointing to ADR-117 (current default) and ADR-124 (policy rename), so the reversed default is unambiguous to readers/enforcement. - ADR-100: this Proposed index still presented superseded sub-decisions (102β118, 103β122) as authoritative and used the pre-composite `#LIMIT#` schema. Add a standing note, mark the superseded rows, and show current composite `#CONFIG` keys alongside the originals. - ADR-013: accept it. It was Proposed yet already superseded ADR-012 β an invalid state. Its decision is complete and already operationalized as .claude/rules/docs-parity.md, so finalize the status. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR collects four commits of ADR consistency cleanup on
main:121 β 124(next free number after123-local-secondary-indexes). Structural collision fix only β no decision content changed, consistent with the ADR immutability rule.## Statusheading with the value on a separate line; normalized to the**Status:**/**Date:**inline format mandated by ADR-000 (Date2026-02-02, from the file's creation commit)./adr consistency:#LIMIT#schema. Mark the superseded rows and show the current composite#CONFIGkeys..claude/rules/docs-parity.md, so finalize the status.This is the main-branch half of a coordinated cleanup. The other halves renumber ADRs on open PRs so the whole sequence is collision-free:
121 β 125123-129 β 126-132(plus the same inherited121 β 124fix)Together these yield a collision-free ADR sequence 121-132.
Test plan
ls docs/adr/12*.mdshows no duplicate ADR numbersgrep -rn "121-policy-rename" docs/returns no stale references# ADR-124: Rename IAM Policies for Clarity**Status:**/**Date:**inline formatmkdocs buildreaches ADRs 114-124 from the nav#CONFIGkeysπ€ Generated with Claude Code