fix(build): compile against stable Zig 0.16.0#14
Open
TanGentleman wants to merge 1 commit into
Open
Conversation
The previous `minimum_zig_version` pinned a 0.16.0-dev tarball that is no
longer hosted on ziglang.org, and `docs/Walk.zig` switched on
`Ast.Node.Tag.asm_legacy` which was removed before the stable 0.16.0
release. As a result `zig build` failed on every released toolchain:
docs/Walk.zig:794:10: error: enum 'zig.Ast.Node.Tag' has no member named 'asm_legacy'
.asm_legacy => {},
Bump `minimum_zig_version` to the released `0.16.0` and drop the no-op
`.asm_legacy` arm so the project builds cleanly on stable Zig.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
zig buildcurrently fails on every released Zig toolchain:minimum_zig_versioninbuild.zig.zonis pinned to0.16.0-dev.205+4c0127566, a dev tarball that is no longer hosted on ziglang.org.docs/Walk.zigswitches onAst.Node.Tag.asm_legacy, which was removed before the 0.16.0 release. Building with stable0.16.0errors out:This is the same class of breakage as #5 / #6, just one Zig cycle later.
Fix
minimum_zig_versionto the released0.16.0..asm_legacy => {},arm. The arm was a no-op, and the surrounding switch is exhaustive — keeping it is a hard compile error on any Zig that no longer carries the enum value.Verification
Built
main.wasmexercised end-to-end via the downstream zigpeek CLI (search_std_lib,get_std_lib_item, builtin lookups) — no behavior change.Notes