Conversation
jprzimba
changed the title
gabrielew
reviewed
Nov 10, 2025
| self->flushBatchedTrackerData(); | ||
| }, | ||
| "Player::flushBatchedTrackerData" | ||
| ); |
Contributor
There was a problem hiding this comment.
if you sum the amount, it'll create a bug with the "max-dps" and "all-time high"
But if you don’t sum it, you’ll send all of them separately so it’ll be the same, right?
Collaborator
Author
There was a problem hiding this comment.
Yes, sending impact events separately is the right behavior, and it’s what the code already does.
gabrielew
reviewed
Nov 10, 2025
|
|
||
| // Send aggregated loot stats | ||
| if (batchedTrackerData.lootValue > 0) { | ||
| g_metrics().addCounter("player_loot", batchedTrackerData.lootValue, { { "player", getName() } }); |
Contributor
There was a problem hiding this comment.
duplicated info in g_metrics()
g_metrics().addCounter("player_loot", value, { { "player", getName() } });
- Previous behavior: flushBatchedTrackerData emitted a single aggregated counter using batchedTrackerData.lootValue ( src/creatures/players/player.cpp:1756 ). - Change: Emit one counter per loot item using its computed value (coins or “Lootmonger” sell price) during the loop over lootItems . Removed the aggregated emission. - Result: Metrics reflect each loot event individually and avoid double-reporting caused by batch aggregation.
Contributor
|
This PR is stale because it has been open 45 days with no activity. |
Decreased the tracker batch event delay from 250ms to 50ms for faster updates. Simplified the loot value calculation in flushBatchedTrackerData by aggregating loot value directly and sending metrics only if lootValue is positive. Also added calls to sendStats() and sendSkills() in onCreatureAppear.
jprzimba
changed the title
Contributor
|
This PR is stale because it has been open 45 days with no activity. |
Contributor
|
This PR is stale because it has been open 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracker Functions Optimization
Batching has been implemented for tracker functions to reduce I/O and allocations:
Changes Implemented:
BatchedTrackerDatato accumulate loot, supply, impact, and input datasendLootStats: Accumulates items and values, schedules flush in 250msupdateSupplyTracker: Accumulates items and values, schedules flush in 250msupdateImpactTracker: Accumulates combat data, schedules flush in 250msupdateInputAnalyzer: Accumulates input data, schedules flush in 250msflushBatchedTrackerData: Sends aggregated data and clears the bufferBenefits:
Impact: