🧹 [code health: type safety] Replace 'any' with explicit 'SqlValue' type in sql.js declarations#314
Conversation
…ype in sql.js declarations
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎯 What: Removed usage of
anyinsrc/declarations.d.tsby introducing an explicitSqlValuetype (number | string | Uint8Array | null).💡 Why: Using explicit typing instead of
anysignificantly improves type safety, prevents accidental mistakes, and serves as better code documentation, increasing maintainability of oursql.jsinterfaces.✅ Verification: Tests run via
bun test tests/unit/sqlite-db.test.tsand bundle-free type checks ran successfully onWasmDatabaseEngine.ts.✨ Result: The codebase now complies with standard strict TypeScript practices, reducing the risk of incorrectly passing unintended runtime data via
sql.jsobjects.PR created automatically by Jules for task 10765078713868175552 started by @zknpr