🧹 [Strict Types] Replace "any" types in declarations.d.ts with strict SqlValue and BindParams#317
Conversation
…ams in declarations.d.ts
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎯 What: Replaced the generic
anytypes insrc/declarations.d.tswith explicitSqlValueandBindParamstypes exported directly in the definition module.💡 Why: By avoiding
anywe improve the code's type safety and catch potential errors at compile-time when passing data to and from thesql.jsnative methods. TheSqlValuestrictly defines SQLite-supported primitives whileBindParamsproperly captures arrays or records.✅ Verification: Verified by compiling the extension (
npm run build) and ensuring the full test suite passes (npm run test) successfully without any type errors or logic breaks.✨ Result: A safer, more maintainable type definition file that enforces proper interactions with the embedded database interface.
PR created automatically by Jules for task 17990904564897957073 started by @zknpr