Skip to content

⚡ Optimize undo column drop by using Promise.all for ADD COLUMN operations #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

⚡ Optimize undo column drop by using Promise.all for ADD COLUMN operations #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core/engine/wasm/WasmDatabaseEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,9 @@ export class WasmDatabaseEngine implements DatabaseOperations {
if (deletedColumns) {
await this.executeQuery('BEGIN TRANSACTION');
try {
for (const col of deletedColumns) {
await this.addColumn(targetTable, col.name, col.type);
}
await Promise.all(
deletedColumns.map(col => this.addColumn(targetTable, col.name, col.type))
);

// Optimize restoration by grouping rows that have identical column sets
// This is done effectively by doing one UPDATE per row for all restored columns
Expand Down