Skip to content

🧪 Add test for stringify error fallback in logging wrapper #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧪 Add test for stringify error fallback in logging wrapper #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/unit/loggingDatabaseOperations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,14 @@ describe('LoggingDatabaseOperations', () => {
assert.ok(mockChannel.lines[0].includes('params: [[Object]]'));
});

it('should fallback to [Object] when JSON.stringify throws', async () => {
const thrower = {
toJSON() { throw new Error('Stringify error'); }
};
await logger.executeQuery('SELECT *', [thrower as any]);
assert.ok(mockChannel.lines[0].includes('params: [[Object]]'));
});

it('should pass through numbers', async () => {
await logger.executeQuery('SELECT *', [123.45]);
assert.ok(mockChannel.lines[0].includes('params: [123.45]'));
Expand Down