More parallel download#12
Closed
holybiber wants to merge 15 commits into
Closed
Conversation
Drop the `force` parameter. this is now handled within the download provider atomically.
Up to 4 languages can be downloaded in parallel to further speed up the download process.
Collaborator
|
@holybiber I have cherry-picked your commit into another branch, and added some tiny changes to it. Once the other PR works, I will close this one, mentioning that it was added/solved on the PR #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @GabrielSousa02 , when reviewing PR #11 I thought: Downloading several languages is still sequential. How about enabling parallel language downloads to further speed the process up?
Cursor implemented this plan and I did a quick check on my phone: Instead of 38s with this it only takes 15s to download all languages. That feels pretty decent now - people don't like to wait, especially if they have good phones and good internet connection.
It's set to downloading up to 4 languages in parallel (so that's 8 files fetching concurrently) - we could also fine-tune and try out 5 or so but probably there is not much more to gain.
Can you have a look at it if it makes sense to you and you understand what it does?
I'm not so much into the code that I fully read everything but it looked reasonable and when I tried it on my phone it worked, integration test also runs through so I thought "why not"
Anyway I think in the future we could also provide one repo that has all languages, for those users who just want to have all languages always. But that would require work on the backend and is out of scope here.