[feat] enable-parallel-download#14
Merged
Merged
Conversation
Up to 4 languages can be downloaded in parallel to further speed up the download process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add parallel download of languages, up to 4 at a time.
Why?
This dramatically increases the speed of the app setup with multiple translations.
How?
Created a function that runs downloads in parallel, based of a list of languages that have been
requested by the user on the language setup menu.
A pull of workers keeps running with 4 workers downloading the files on the background.
The downloads are managed by the worker's pool, and not by incremental batch of four on a list, this way
if one download of the batch is taking longer for any particular reason, the other workers get spawned and
continue with the next item on the list, instead of the entire batch being help up before another batch can start.
Testing?
All tests are passing.
Screenshots (optional)
N/A
Anything Else?
The PR #12 is what ignited this improvement.