Add non-local release evidence intake runbook#169
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Author
|
@coderabbitai review |
📝 WalkthroughWalkthroughAdds a comprehensive non-local release evidence intake runbook ( ChangesNon-Local Release Evidence Intake Runbook
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/non-local-release-evidence.md (1)
308-309:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRemove the trailing blank line at EOF.
The extra newline is already failing the Foundry smoke formatting check in CI.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/non-local-release-evidence.md` around lines 308 - 309, The Markdown document named non-local-release-evidence.md ends with an extra blank line that fails the Foundry smoke formatter; open the document, remove the trailing empty newline so the file ends immediately after the last content line (no extra blank line or whitespace at EOF), save and commit the change so the formatter check will pass.Source: Pipeline failures
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/public-beta-evidence.md`:
- Around line 102-107: Update the intake gate so evidence families
"production_broadcast_retention" and "production_address_books" are treated like
the other retained families that require the non-local release evidence intake
runbook review: modify the docs step that lists the runbook check (the line
calling the "non-local release evidence intake runbook") to explicitly include
those two families, and update the enforcement logic in
check_public_beta_evidence.py to mark any requirement depending on
production_broadcast_retention or production_address_books as needing the
runbook (so they cannot reach "complete" without review); keep risk_acceptance
behavior unchanged and ensure the release manifest/checksum bundle regeneration
still runs.
In `@ops/ROADMAP.md`:
- Around line 2189-2193: Update the listed bullets that currently say generic
“signature” or “signed-tag” to explicitly call out the checksum-backed
production-signature family (e.g., “checksum-backed production-signature” or
“production-signature (checksum-backed)”) so the intake scope matches
docs/non-local-release-evidence.md; search for the phrases "signature" and
"signed-tag" in the affected bullets (including the repeated instance at the
other location) and replace or augment them with the explicit checksum-backed
production-signature wording to keep Gate G aligned with the runbook.
- Line 2402: The ROADMAP entry for "Release artifact catalog" incorrectly
implies docs/non-local-release-evidence.md is generated; update the table text
so the runbook is listed as an input (not a generated artifact). Edit the
"Release artifact catalog" row in ops/ROADMAP.md: change the phrase(s) that
suggest machine-generation (e.g., "non-local evidence intake" and the placement
of `docs/non-local-release-evidence.md`) to explicitly call it a maintained
governance input/runbook (for example "non-local release evidence runbook
(input): docs/non-local-release-evidence.md") so the docs file is not presented
as a generated artifact.
---
Outside diff comments:
In `@docs/non-local-release-evidence.md`:
- Around line 308-309: The Markdown document named non-local-release-evidence.md
ends with an extra blank line that fails the Foundry smoke formatter; open the
document, remove the trailing empty newline so the file ends immediately after
the last content line (no extra blank line or whitespace at EOF), save and
commit the change so the formatter check will pass.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 10cedc74-dbfe-485b-868d-2814cdb70335
📒 Files selected for processing (16)
CHANGELOG.mddocs/non-local-release-evidence.mddocs/public-beta-evidence.mddocs/release-policy.mddocs/release-readiness.mddocs/tooling.mdops/AUTONOMOUS_RUN.mdops/ROADMAP.mdrelease-artifacts/README.mdrelease-artifacts/latest/SHA256SUMSrelease-artifacts/latest/release-checksums.jsonrelease-artifacts/latest/release-manifest.jsonscripts/check_release_readiness.pyscripts/generate_release_manifest.pyscripts/test_release_manifest.pyscripts/test_release_readiness.py
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ops/AUTONOMOUS_RUN.md`:
- Around line 149-152: Update the Status line under the "PR candidate: Add
non-local release evidence intake runbook (Queue Item 87)" heading to reflect
the true phase for PR `#169` — replace "CodeRabbit follow-up implemented and
validated locally; ready to push follow-up commit and wait for final
CI/CodeRabbit rerun." with a clear state such as "follow-up pushed; awaiting
CI/CodeRabbit verification" or "follow-up merged; CI/CodeRabbit passed" as
appropriate, so the resume state is unambiguous for the next operator.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e2ba78f5-ae53-4d9b-8ac4-7510052e6016
📒 Files selected for processing (8)
docs/public-beta-evidence.mdops/AUTONOMOUS_RUN.mdops/ROADMAP.mdrelease-artifacts/latest/SHA256SUMSrelease-artifacts/latest/release-checksums.jsonrelease-artifacts/latest/release-manifest.jsonscripts/check_public_beta_evidence.pyscripts/test_public_beta_evidence.py
✅ Files skipped from review due to trivial changes (3)
- release-artifacts/latest/SHA256SUMS
- release-artifacts/latest/release-checksums.json
- ops/ROADMAP.md
🚧 Files skipped from review as they are similar to previous changes (2)
- docs/public-beta-evidence.md
- release-artifacts/latest/release-manifest.json
Comment on lines
+149
to
+152
| ### PR candidate: Add non-local release evidence intake runbook (Queue Item 87) | ||
|
|
||
| Status: CodeRabbit follow-up addressed locally; refreshed CI and CodeRabbit | ||
| status pending after push. | ||
| Status: CodeRabbit follow-up implemented and validated locally; ready to push | ||
| follow-up commit and wait for final CI/CodeRabbit rerun. |
There was a problem hiding this comment.
Make the PR #169 status reflect the actual phase.
This says the follow-up is still “ready to push,” but the later notes already describe the follow-up fixes and regenerated artifacts. That makes the resume state ambiguous for the next operator.
Suggested cleanup
-Status: CodeRabbit follow-up implemented and validated locally; ready to push follow-up commit and wait for final CI/CodeRabbit rerun.
+Status: CodeRabbit follow-up is implemented locally; next step is to push the follow-up commit and rerun CI/CodeRabbit.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ops/AUTONOMOUS_RUN.md` around lines 149 - 152, Update the Status line under
the "PR candidate: Add non-local release evidence intake runbook (Queue Item
87)" heading to reflect the true phase for PR `#169` — replace "CodeRabbit
follow-up implemented and validated locally; ready to push follow-up commit and
wait for final CI/CodeRabbit rerun." with a clear state such as "follow-up
pushed; awaiting CI/CodeRabbit verification" or "follow-up merged; CI/CodeRabbit
passed" as appropriate, so the resume state is unambiguous for the next
operator.
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #168.
docs/non-local-release-evidence.mdas the no-secret intake runbook for fork/testnet/live, audit, explorer, gas, invariant, checksum-signature, and signed-tag evidence.Validation
python scripts/test_release_readiness.pypython scripts/check_release_readiness.pypython scripts/test_release_manifest.pypython scripts/generate_release_manifest.py --checkpython scripts/generate_release_checksums.py --checkpython scripts/check_public_beta_evidence.pypython scripts/check_changelog.pypython -m py_compile scripts\check_release_readiness.py scripts\test_release_readiness.py scripts\generate_release_manifest.py scripts\test_release_manifest.pyrg -n "^#|^##|^###" docs\non-local-release-evidence.md docs\release-readiness.md docs\public-beta-evidence.md docs\release-policy.md docs\tooling.md ops\ROADMAP.md ops\AUTONOMOUS_RUN.mdgit diff --checkmake checkNotes
No Solidity behavior changes. This PR is documentation, release-check tooling, generated release evidence, roadmap, and run-state only.
Summary by CodeRabbit