Link release evidence backlog entries to tracker issues#232
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
@coderabbitai review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR adds deterministic mapping from release-evidence backlog entries to GitHub tracker issues via a committed no-secret JSON artifact. It includes a validator script, unit tests, manifest integration, build-pipeline wiring, and comprehensive documentation updates reflecting the new validation gate and release-readiness criteria. ChangesRelease Evidence Issue Links
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/check_release_evidence_issue_links.py`:
- Around line 44-50: The load_json function currently only catches
FileNotFoundError and json.JSONDecodeError; extend its exception handling to
also catch unreadable/IO and decode errors so they surface as validation
failures: catch OSError (which covers PermissionError and other IO problems) and
UnicodeDecodeError raised by path.open()/read, and re-raise them as
ReleaseEvidenceIssueLinksError with a clear message referencing the path (e.g.,
"unable to read {path}: {exc}" or "invalid encoding in {path}: {exc}"). Keep the
existing FileNotFoundError and json.JSONDecodeError handlers unchanged and use
the same pattern of "raise ReleaseEvidenceIssueLinksError(...) from exc" so
callers of load_json receive consistent failure semantics.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 87090629-71a8-4638-a330-b817a15b830f
📒 Files selected for processing (23)
.github/workflows/ci.ymlCHANGELOG.mdMakefiledocs/public-beta-evidence.mddocs/release-readiness.mddocs/tooling.mdops/AUTONOMOUS_RUN.mdops/ROADMAP.mdrelease-artifacts/README.mdrelease-artifacts/latest/SHA256SUMSrelease-artifacts/latest/release-checksums.jsonrelease-artifacts/latest/release-evidence-issue-links.jsonrelease-artifacts/latest/release-manifest.jsonscripts/check.ps1scripts/check.shscripts/check_release_evidence_issue_links.pyscripts/check_release_readiness.pyscripts/generate_release_artifacts.pyscripts/generate_release_manifest.pyscripts/test_release_artifacts.pyscripts/test_release_evidence_issue_links.pyscripts/test_release_manifest.pyscripts/test_release_readiness.py
|
@coderabbitai review |
✅ Action performedReview finished.
|
1 participant
Summary
release-artifacts/latest/release-evidence-issue-links.json, a deterministic no-secret map from every generated release-evidence backlog row to a concrete GitHub tracker issue.scripts/check_release_evidence_issue_links.pyplus focused tests for missing links, stale entry IDs, URL/number mismatches, duplicate issue numbers, and CLI failure reporting.make check, shell/PowerShell wrappers, CI, release manifest/checksum artifacts, release docs, roadmap, and the autonomous run state.Validation
python -m py_compile scripts/check_release_evidence_issue_links.py scripts/test_release_evidence_issue_links.py scripts/generate_release_manifest.py scripts/test_release_manifest.py scripts/check_release_readiness.py scripts/test_release_readiness.py scripts/generate_release_artifacts.py scripts/test_release_artifacts.pypython scripts/test_release_evidence_issue_links.pypython scripts/check_release_evidence_issue_links.pypython scripts/test_release_artifacts.pypython scripts/test_release_manifest.pypython scripts/test_release_readiness.pypython scripts/check_release_readiness.pypython scripts/test_changelog_check.pypython scripts/check_changelog.pypython scripts/generate_release_manifest.py --checkpython scripts/generate_release_checksums.py --checkpython scripts/generate_release_artifacts.py --checkbash -n scripts/check.shscripts/check.ps1rg -n "^#|^##|^###" ops/ROADMAP.md ops/AUTONOMOUS_RUN.md docs/release-readiness.md docs/public-beta-evidence.md release-artifacts/README.md docs/tooling.mdgit diff --check(passes with the existing Windows LF-to-CRLF warning forscripts/check.ps1)make check(passes with existing Solidity compiler and Foundry trace warning noise only)Closes #214
Summary by CodeRabbit
New Features
Tests
Documentation
Chores