Make build task expiration timeout configurable#1227
Open
ConnorFreebairn wants to merge 1 commit into
Open
Conversation
The window for treating a build task as expired was hardcoded to 20 minutes in get_available_build_task. Moved it into a new build_task_expiration_minutes setting (default 20) so deployments can tune how long a task may go without a ping from its build node before it becomes available for a node to pick up again. Fixes: AlmaLinux/build-system#284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The time before an in-progress build task is considered expired was hard coded to 20 minutes in get_available_build_task. This moves it into a new build_task_expiration_minutes setting (default 20), so behavior is unchanged unless it's overridden.
This is the web server / app half of AlmaLinux/build-system#284
Fixes: AlmaLinux/build-system#284