Skip to content

Make build task expiration timeout configurable #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ConnorFreebairn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make build task expiration timeout configurable #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions alws/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ class Settings(BaseSettings):

logging_level: Optional[str] = 'INFO'

build_task_expiration_minutes: int = 20

frontend_baseurl: Annotated[str, Field(validate_default=True)] = (
'http://localhost:8080'
)
Expand Down
5 changes: 3 additions & 2 deletions alws/crud/build_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ async def get_available_build_task(
db: AsyncSession,
request: build_node_schema.RequestTask,
) -> typing.Optional[models.BuildTask]:
# TODO: here should be config value
ts_expired = datetime.datetime.utcnow() - datetime.timedelta(minutes=20)
ts_expired = datetime.datetime.utcnow() - datetime.timedelta(
minutes=settings.build_task_expiration_minutes
)
exclude_condition = (
sqlalchemy.not_(
sqlalchemy.or_(*[
Expand Down