Refactor Create Bodies From Parser [SYNTH-215]

[azaleacolburn]

Task

SYNTH-215

Symptom

The createBodiesFromParser method in PhysicsSystem.ts was very messy and difficult to debug (for me at least).

This was especially a problem because when updating the version of JoltPhysics.js we use, in SYNTH-211, the createBodiesFromParser method stopped working. After reviewing the Jolt changlog between versions 0.31.0 and 1.0.1, I determined that this was likely an existing bug in the method that went unnoticed before.

In order to properly debug this function, I thought it would be helpful to first refactor it.

Solution

In addition to general refactoring, a new file has been created src/systems/physics/CreateBodiesFromParser.ts, which exposes one function, createBodiesFromParser, which is assigned to the method of the same name on the PhysicsSystem class.

I think this is a pattern we should continue using for every bundle of methods that supply some functionality to the physics system, as having one 2000 line file isn't very maintainable, especially not one cluttered with helper functions.

Verification

All tests still pass.

---

Before merging, ensure the following criteria are met:

• All acceptance criteria outlined in the ticket are met.
• Necessary test cases have been added and updated.
• A feature toggle or safe disable path has been added (if applicable).
• User-facing polish:
  • Ask: "Is this ready-looking?"
• Cross-linking between Jira and GitHub:
  • PR links to the relevant Jira issue.
  • Jira ticket has a comment referencing this PR.