URDF Import Improvements [SYNTH-196]#1426
Conversation
AlexD717
left a comment
There was a problem hiding this comment.
I was unable to import the provided KitBot 2026 model, but was able to do it on dev. If this is unrelated to your PR I am fine approving, but both the Kitbot and my teams model could be imported on dev but can't be here.
that's a great point and I can now do this too. Something might've changed since I started working on this but yes this does appear to be a regression now |
|
It looks like the underlying issue is due to the size of URDF models (because of the detail of the mesh), and the mirabuf encoding process. The caching therefore shouldn't be merged until that's addressed (perhaps by simplifying the meshes on import). I think I'll remove the caching but leave the progress bar in and make a separate ticket for the caching (SYNTH-264) |
Task
SYNTH-196
Symptom
URDF importing previously had no visual indication of what was happening.
Solution
A progress bar for the conversion is shown to indicate what is going on. Code to enable caching is provided but not used due to the complexity of URDF meshes (it requires too much memory to encode)
Verification
Import a robot model and observe that you have a progress bar (if you do dozer, you might want to consider slowing down your CPU in chrome devtools to see the toasts).
URDF_Dozer.zip
URDF Kitbot
Before merging, ensure the following criteria are met: