Skip to content

URDF Import Improvements [SYNTH-196]#1426

Open
rutmanz wants to merge 12 commits into
devfrom
zachr/196/urdf-cache
Open

URDF Import Improvements [SYNTH-196]#1426
rutmanz wants to merge 12 commits into
devfrom
zachr/196/urdf-cache

Conversation

@rutmanz

@rutmanz rutmanz commented Jul 20, 2026

Copy link
Copy Markdown
Member

Task

SYNTH-196

Symptom

URDF importing previously had no visual indication of what was happening.

Solution

A progress bar for the conversion is shown to indicate what is going on. Code to enable caching is provided but not used due to the complexity of URDF meshes (it requires too much memory to encode)

Verification

Import a robot model and observe that you have a progress bar (if you do dozer, you might want to consider slowing down your CPU in chrome devtools to see the toasts).

URDF_Dozer.zip

URDF Kitbot


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@rutmanz rutmanz self-assigned this Jul 20, 2026
@rutmanz
rutmanz requested review from a team as code owners July 20, 2026 17:06
@rutmanz rutmanz added ui/ux Relating to user interface, or in general, user experience importer labels Jul 20, 2026
@rutmanz
rutmanz requested a review from PepperLola July 20, 2026 17:06

@AlexD717 AlexD717 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to import the provided KitBot 2026 model, but was able to do it on dev. If this is unrelated to your PR I am fine approving, but both the Kitbot and my teams model could be imported on dev but can't be here.

Comment thread fission/src/ui/components/ProgressNotification.tsx Outdated
Comment thread fission/src/urdf/URDFLoader.ts Outdated
@rutmanz
rutmanz marked this pull request as draft July 20, 2026 21:44
@rutmanz

rutmanz commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

I was unable to import the provided KitBot 2026 model, but was able to do it on dev. If this is unrelated to your PR I am fine approving, but both the Kitbot and my teams model could be imported on dev but can't be here.

that's a great point and I can now do this too. Something might've changed since I started working on this but yes this does appear to be a regression now

@rutmanz

rutmanz commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

It looks like the underlying issue is due to the size of URDF models (because of the detail of the mesh), and the mirabuf encoding process. The caching therefore shouldn't be merged until that's addressed (perhaps by simplifying the meshes on import).

I think I'll remove the caching but leave the progress bar in and make a separate ticket for the caching (SYNTH-264)

@rutmanz
rutmanz marked this pull request as ready for review July 20, 2026 22:45
@rutmanz
rutmanz requested a review from AlexD717 July 20, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

importer ui/ux Relating to user interface, or in general, user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants