📦 Fixes BlueBaseModule bug that resolve all promises, not just one#32
Open
artalat wants to merge 3 commits into
Open
📦 Fixes BlueBaseModule bug that resolve all promises, not just one#32artalat wants to merge 3 commits into
artalat wants to merge 3 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #32 +/- ##
========================================
Coverage 99.41% 99.41%
========================================
Files 94 94
Lines 1028 1028
Branches 152 152
========================================
Hits 1022 1022
Misses 6 6Continue to review full report at Codecov.
|
artalat
commented
Dec 26, 2018
| expect(obj.foo).toBe('bar'); | ||
| expect(module.loaded).toBe(true); | ||
| }); | ||
| expect(module1.loaded).toBe(false); |
Contributor
Author
There was a problem hiding this comment.
What happens if you move this test inside the then callback? @omarnaeem0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug is reported in BlueBaseModules. When resolving a single module, all modules are resolved. This PR tracks this bug.