Skip to content

📦 Fixes BlueBaseModule bug that resolve all promises, not just one #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artalat wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

📦 Fixes BlueBaseModule bug that resolve all promises, not just one #32

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66936a8
test(📦 BlueBaseModule): Added test to highlight the bug.
artalat Dec 25, 2018
c1e90ea
fix(BlueBaseModule): test case passed by using promise.then rather th…
omarnaeem0 Dec 26, 2018
648ae6e
test(BlueBaseModule): prettier fixed
omarnaeem0 Dec 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions src/utils/tests/BlueBaseModule.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,19 +56,17 @@ describe('Utils', () => {
expect(obj.foo).toBe('bar');
});

// it('should set loaded prop of only the loaded item', async () => {

// // FIXME: Big bug!!!
// const module = createBlueBaseModule({ foo: 'bar' });
// const module1 = createBlueBaseModule({ foo: 'baz' });
// expect(module.loaded).toBe(false);
// expect(module1.loaded).toBe(false);

// const obj = await module;
it('should set loaded prop of only the loaded item', () => {
const module = createBlueBaseModule({ foo: 'bar' });
const module1 = createBlueBaseModule({ foo: 'baz' });
expect(module.loaded).toBe(false);
expect(module1.loaded).toBe(false);

// expect(obj.foo).toBe('bar');
// expect(module.loaded).toBe(true);
// expect(module1.loaded).toBe(false);
// });
module.then(obj => {
expect(obj.foo).toBe('bar');
expect(module.loaded).toBe(true);
});
expect(module1.loaded).toBe(false);

@artalat artalat Dec 26, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you move this test inside the then callback? @omarnaeem0

@omarnaeem0 omarnaeem0 Dec 26, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artalat sir are you referring to the line 69?

@artalat artalat Dec 26, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

});
});
});