London | ITP-Jan-26 | Maryanne Mosonik | Sprint 3 | Alarm Clock#1091
Open
Maryanne-K wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London | ITP-Jan-26 | Maryanne Mosonik | Sprint 3 | Alarm Clock#1091Maryanne-K wants to merge 1 commit intoCodeYourFuture:mainfrom
Maryanne-K wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
Maryanne-K
added
the
Needs Review
Luro91
added
Reviewed
Luro91
reviewed
Apr 4, 2026
| function setAlarm() { | ||
| const input = document.getElementById("alarmSet"); | ||
| const seconds = parseInt(input.value, 10); | ||
| if (isNaN(seconds) || seconds <= 0) return; |
There was a problem hiding this comment.
Nice validation of the user input. Its important to always validate the user data.
How could you inform the user about that the input is invalid?
Comment on lines
+4
to
+6
| function setAlarm() { | ||
| const input = document.getElementById("alarmSet"); | ||
| const seconds = parseInt(input.value, 10); |
There was a problem hiding this comment.
The intentadion of the code seems incorrect. How can you ensure that the format is always consistent based on agreed rules?
|
|
||
| if (remainingTime <= 0) { | ||
| clearInterval(countdown); | ||
| if (typeof playAlarm === "function") { |
There was a problem hiding this comment.
Why do you need to check if playAlarm is a function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
This is Sprint 3 backlog on building an alarm clock.