Skip to content

London | ITP-Jan-26 | Maryanne Mosonik | Sprint 3 | Alarm Clock #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maryanne-K wants to merge 1 commit into
base: main
Choose a base branch
from
+72 −2
Open

London | ITP-Jan-26 | Maryanne Mosonik | Sprint 3 | Alarm Clock #1091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions Sprint-3/alarmclock/Module-Data-Groups.code-workspace
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"folders": [
{
"path": "../.."
},
{
"name": "Sprint-1",
"path": "../../Sprint-1"
},
{
"name": "Sprint-2",
"path": "../../Sprint-2"
},
{
"name": "Sprint-3",
"path": ".."
},
{
"name": "slideshow",
"path": "../slideshow"
},
{
"name": "reading-list",
"path": "../reading-list"
},
{
"name": "alarmclock",
"path": "."
},
{
"name": "todo-list",
"path": "../todo-list"
},
{
"name": "quote-generator",
"path": "../quote-generator"
}
]
}
33 changes: 32 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,35 @@
function setAlarm() {}
let countdown;
let remainingTime = 0;

function setAlarm() {
const input = document.getElementById("alarmSet");
const seconds = parseInt(input.value, 10);
Comment on lines +4 to +6
Copy link
Copy Markdown

@Luro91 Luro91 Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intentadion of the code seems incorrect. How can you ensure that the format is always consistent based on agreed rules?

if (isNaN(seconds) || seconds <= 0) return;
Copy link
Copy Markdown

@Luro91 Luro91 Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice validation of the user input. Its important to always validate the user data.

How could you inform the user about that the input is invalid?


clearInterval(countdown);
remainingTime = seconds;

const display = document.getElementById("timeRemaining");
display.textContent = `Time Remaining: ${formatTime(remainingTime)}`;

countdown = setInterval(() => {
remainingTime--;
display.textContent = `Time Remaining: ${formatTime(remainingTime)}`;

if (remainingTime <= 0) {
clearInterval(countdown);
if (typeof playAlarm === "function") {
Copy link
Copy Markdown

@Luro91 Luro91 Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to check if playAlarm is a function?

window.playAlarm();
}
}
}, 1000);
}

function formatTime(seconds) {
const mins = String(Math.floor(seconds / 60)).padStart(2, "0");
const secs = String(seconds % 60).padStart(2, "0");
return `${mins}:${secs}`;
}

// DO NOT EDIT BELOW HERE

Expand Down
2 changes: 1 addition & 1 deletion Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm Clock App</title>
</head>
<body>
<div class="centre">
Expand Down
Loading