Skip to content

fix(Pagination): Previous and Next Buttons to respect RTL#3316

Draft
LinKCoding wants to merge 5 commits intocass-gmt-1601from
kl-gmt-1592
Draft

fix(Pagination): Previous and Next Buttons to respect RTL#3316
LinKCoding wants to merge 5 commits intocass-gmt-1601from
kl-gmt-1592

Conversation

@LinKCoding
Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding commented Apr 3, 2026

Overview

Updates the Pagination component to use the correct Icon for Previous and Next that respect the dir of the parent element.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1592
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to the pagination story
  2. Toggle between RTL/LTR on the story page and see that the Previous/Next buttons render correctly
  3. Click on an individual story/canvas and see that the buttons still render correctly
  4. (optionally) Check it with VO
  5. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Mono Mono PR

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Apr 3, 2026

View your CI Pipeline Execution ↗ for commit 02e01c8


☁️ Nx Cloud last updated this comment at 2026-04-07 18:26:02 UTC

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (cass-gmt-1601@e0b009f). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##             cass-gmt-1601    #3316   +/-   ##
================================================
  Coverage                 ?   89.18%           
================================================
  Files                    ?      250           
  Lines                    ?     4698           
  Branches                 ?     1589           
================================================
  Hits                     ?     4190           
  Misses                   ?      500           
  Partials                 ?        8           
Flag Coverage Δ
pull-request 89.18% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LinKCoding LinKCoding changed the base branch from main to cass-gmt-1601 April 3, 2026 16:32
@codecademydev
Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 68.2.3-alpha.d27b20.0 npm diff
@codecademy/gamut-icons 9.57.3-alpha.d27b20.0 npm diff
@codecademy/gamut-illustrations 0.58.10-alpha.d27b20.0 npm diff
@codecademy/gamut-kit 0.6.593-alpha.d27b20.0 npm diff
@codecademy/gamut-patterns 0.10.29-alpha.d27b20.0 npm diff
@codecademy/gamut-styles 17.13.2-alpha.d27b20.0 npm diff
@codecademy/gamut-tests 5.3.4-alpha.d27b20.0 npm diff
@codecademy/variance 0.26.2-alpha.d27b20.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.d27b20.0 npm diff

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants