Skip to content

fix(Pagination): Previous and Next Buttons to respect RTL #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LinKCoding merged 7 commits into from
Apr 14, 2026
+17 −5
Merged

fix(Pagination): Previous and Next Buttons to respect RTL #3316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
db33295
using useIsRTL hook in pagination
LinKCoding Apr 3, 2026
1bd5904
updates to make RTL work for canvas embedded in a Storybook doc page
LinKCoding Apr 3, 2026
98d0a4a
formatted
LinKCoding Apr 3, 2026
678ce52
add plan
LinKCoding Apr 3, 2026
dc48638
update hook
LinKCoding Apr 7, 2026
c5fcdc7
fix isRtl assignment in pagination
LinKCoding Apr 8, 2026
b73a384
revert changes to GamutThemeProvider
LinKCoding Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .nx/version-plans/version-plan-1775234017199.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
gamut-styles: minor
gamut: minor
---

Updates the Pagination component to have its Previous/Next buttons' icon reflect the correct dir
16 changes: 11 additions & 5 deletions packages/gamut/src/Pagination/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@ import {
MiniChevronLeftIcon,
MiniChevronRightIcon,
} from '@codecademy/gamut-icons';
import { useMemo, useState } from 'react';
import { useElementDir } from '@codecademy/gamut-styles';
import { useMemo, useRef, useState } from 'react';
import * as React from 'react';

import { HiddenText } from '..';
import { Text } from '..';
import { FlexBox } from '../Box';
import {
AnimatedFadeButton,
Expand Down Expand Up @@ -72,6 +73,8 @@ export const Pagination: React.FC<PaginationProps> = ({
);
const [liveText, setLiveText] = useState('');
const [shownPageArray, setShownPageArray] = useState([0]);
const rootRef = useRef<HTMLDivElement>(null);
const isRtl = useElementDir(rootRef) === 'rtl';

const showSkipToButtons = !!(
(type === undefined && totalPages >= 10) ||
Expand Down Expand Up @@ -145,13 +148,16 @@ export const Pagination: React.FC<PaginationProps> = ({
_: 'initial',
sm: `${showSkipToButtons ? getMinWidth({ chapterSize }) : 'initial'}`,
}}
ref={rootRef}
>
<HiddenText aria-live="polite">{liveText}</HiddenText>
<Text aria-live="polite" screenreader>
{liveText}
</Text>
<AnimatedFadeButton
aria-label={`Navigate back to page ${currentPage - 1}`}
buttonType={variant}
href={navigation}
icon={MiniChevronLeftIcon}
icon={isRtl ? MiniChevronRightIcon : MiniChevronLeftIcon}
showButton={currentPage === 1 ? 'hidden' : 'shown'}
onClick={() => changeHandler(currentPage - 1)}
/>
Expand Down Expand Up @@ -230,7 +236,7 @@ export const Pagination: React.FC<PaginationProps> = ({
aria-label={`Navigate forward to page ${currentPage + 1}`}
buttonType={variant}
href={navigation}
icon={MiniChevronRightIcon}
icon={isRtl ? MiniChevronLeftIcon : MiniChevronRightIcon}
showButton={currentPage === totalPages ? 'hidden' : 'shown'}
onClick={() => changeHandler(currentPage + 1)}
/>
Expand Down
Loading