fix(build): correct setup.py exclusion filter (m[0]->m[1]) + resolve E402 late import in cloud_license.py#36
Merged
Conversation
…ed sys import in setup.py
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…y exclusion
find_package_modules returns (package, module, filename) tuples.
m[0] is always the package name ("engraphis"), so the exclusion
filter never matched and .py sources would ship alongside compiled
extensions. Use m[1] to correctly exclude licensing and cloud_license.
Coding-Dev-Tools
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bug fix (setup.py)
build_py.find_package_modules: was comparingm[0](module name) instead ofm[1](file path) against the exclusion pattern, so excluded modules were never actually filtered out.Lint fix (cloud_license.py)
Lint fix (setup.py)
sysimport.CI
All checks passing (3.9 floor, 3.10, 3.11, 3.12, docker, wheel build, browser a11y).